Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ac: update Spanish translation #15348

Merged
merged 2 commits into from
Jan 1, 2025
Merged

ac: update Spanish translation #15348

merged 2 commits into from
Jan 1, 2025

Conversation

kant
Copy link
Member

@kant kant commented Dec 25, 2024

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@kant kant added the translation Issues requesting translating pages from English to other languages. label Dec 25, 2024
@kant kant requested review from tricantivu and ikks as code owners December 25, 2024 04:59
@kbdharun kbdharun changed the title Update ac: Spanish translation ac: update Spanish translation Dec 25, 2024
@sebastiaanspeck sebastiaanspeck removed the translation Issues requesting translating pages from English to other languages. label Jan 1, 2025
@github-actions github-actions bot added the translation edit Changes to an existing translation page(s). label Jan 1, 2025
@sebastiaanspeck
Copy link
Member

@ikks can you provide your review on this PR?

ikks
ikks reviewed Jan 1, 2025
View reviewed changes
Copy link
Collaborator

@ikks ikks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imo Usage of colon is not mandatory in this case. Is not harmful either. feel free to approve it. As usual, attention to detail is welcome. Happy new year.

@sebastiaanspeck sebastiaanspeck merged commit 3da01ee into main Jan 1, 2025
7 checks passed
@sebastiaanspeck sebastiaanspeck deleted the kant-patch-7 branch January 1, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikks ikks ikks left review comments

@spageektti spageektti spageektti approved these changes

@kbdharun kbdharun kbdharun approved these changes

@sebastiaanspeck sebastiaanspeck sebastiaanspeck approved these changes

@tricantivu tricantivu Awaiting requested review from tricantivu tricantivu is a code owner

Assignees
No one assigned
Labels
translation edit Changes to an existing translation page(s).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kant @sebastiaanspeck @ikks @kbdharun @spageektti