✨Search page #2549
Merged
✨Search page #2549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Marxoz
requested changes
Dec 3, 2024
Marxoz
requested changes
Dec 3, 2024
There was a problem hiding this comment.
@joshbermanssw Once we display the search results, the preview results should disappear until a different search is entered
Figure: Preview search results should disapear when we show the results page
This is not apart of this PBI |
Done |
Marxoz
requested changes
Dec 3, 2024
Part of the design - will consult with Betty re: Search Bar #2575 |
Marxoz
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We created a Search Page!
Figma Mockup: https://www.figma.com/proto/Jyj0SszjfSBc6Minkl3g1l/Tina.io?node-id=1503-7209&node-type=frame&t=nFC6xWeRHd0cp8FV-0&scaling=scale-down-width&content-scaling=fixed&page-id=1503:6780&starting-point-node-id=1503:7209
Changes:
PBIs created from this
#2550
#2551
#2553
Figure: Our new docs search page