-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: caluculation for the gravity by slope in ego entity simulation #1477
Merged
+57
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checklist for reviewers ☑️All references to "You" in the following text refer to the code reviewer.
|
…erationBySlope test
…:calculateAccelerationBySlope unit test
HansRobo
added
bump patch
If this pull request merged, bump patch version of the scenario_simulator_v2
wait for regression test
and removed
wait for regression test
labels
Dec 6, 2024
HansRobo
changed the title
fix: pitch angle sign in ego entity simulation
fix: caluculation for the gravity by slope in ego entity simulation
Dec 9, 2024
hakuturu583
requested changes
Dec 9, 2024
simulation/simple_sensor_simulator/test/src/vehicle_simulation/test_ego_entity_simulation.cpp
Outdated
Show resolved
Hide resolved
simulation/simple_sensor_simulator/test/src/vehicle_simulation/test_ego_entity_simulation.cpp
Outdated
Show resolved
Hide resolved
hakuturu583
approved these changes
Dec 9, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
bump patch
If this pull request merged, bump patch version of the scenario_simulator_v2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Abstract
fix caluculation for the gravity by slope in ego entity simulation
Background
This bug was introduced in #1447
Details
accelerlation_by_slope
The
accelerlation_by_slope
caluculation is was done as shown in the figure below and reflected in the code.References
Regression Test: OK
Destructive Changes
Known Limitations