Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: caluculation for the gravity by slope in ego entity simulation #1477

Merged
merged 7 commits into from
Dec 9, 2024

Conversation

HansRobo
Copy link
Member

@HansRobo HansRobo commented Dec 5, 2024

Description

Abstract

fix caluculation for the gravity by slope in ego entity simulation

Background

This bug was introduced in #1447

Details

  • use pitch-filled map pose for ego pitch calculation
  • fix sign in caluculation of accelerlation_by_slope
  • fix pitch caluculation in tests

The accelerlation_by_slope caluculation is was done as shown in the figure below and reflected in the code.

image

References

Regression Test: OK

Destructive Changes

Known Limitations

Copy link

github-actions bot commented Dec 5, 2024

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@HansRobo HansRobo added the bug Something isn't working label Dec 5, 2024
@HansRobo HansRobo added bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 wait for regression test and removed wait for regression test labels Dec 6, 2024
@HansRobo HansRobo changed the title fix: pitch angle sign in ego entity simulation fix: caluculation for the gravity by slope in ego entity simulation Dec 9, 2024
@HansRobo HansRobo requested a review from hakuturu583 December 9, 2024 04:40
@HansRobo HansRobo marked this pull request as ready for review December 9, 2024 04:40
@HansRobo HansRobo merged commit fcaf62b into master Dec 9, 2024
14 checks passed
@github-actions github-actions bot deleted the fix/acc_by_slope branch December 9, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working bump patch If this pull request merged, bump patch version of the scenario_simulator_v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants