Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Player] Add OfflinePrivilegeCheck to bootstrap process #96

Merged
merged 4 commits into from
Nov 5, 2024
Merged

[Player] Add OfflinePrivilegeCheck to bootstrap process #96

merged 4 commits into from
Nov 5, 2024

Conversation

asendra
Copy link
Collaborator

@asendra asendra commented Sep 19, 2024 •
edited
Loading

We want to be able to check inside PlaybackEngine if the user has permissions to play an offlined track.

@asendra asendra force-pushed the alberto/offline-privilege-check branch from b4acb67 to 681a73a Compare September 19, 2024 10:11
@asendra asendra force-pushed the alberto/offline-privilege-check branch from 4f3a97c to 7d203b1 Compare October 7, 2024 14:34
@asendra asendra marked this pull request as ready for review October 10, 2024 14:58
@asendra asendra requested a review from a team as a code owner October 10, 2024 14:58
@asendra asendra force-pushed the alberto/offline-privilege-check branch from 7d203b1 to 70167cd Compare October 10, 2024 14:59
ceciliasaraiva
ceciliasaraiva approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@ceciliasaraiva ceciliasaraiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super small suggestion

Sources/Player/PlaybackEngine/Internal/PlayerItemLoader.swift Outdated Show resolved Hide resolved
@asendra asendra force-pushed the alberto/offline-privilege-check branch from 70167cd to c301099 Compare October 11, 2024 10:50
@asendra asendra marked this pull request as draft October 16, 2024 09:30
@asendra asendra force-pushed the alberto/offline-privilege-check branch from c301099 to 2ae8dab Compare October 16, 2024 09:31
@asendra asendra force-pushed the alberto/offline-privilege-check branch from 2ae8dab to 24ad51a Compare November 5, 2024 15:24
@asendra asendra changed the title Add OfflinePrivilegeCheck to bootstrap process [Player] Add OfflinePrivilegeCheck to bootstrap process Nov 5, 2024
@asendra asendra marked this pull request as ready for review November 5, 2024 15:24
@asendra asendra changed the base branch from main to alberto/player-disable-expiry-check November 5, 2024 15:25
Base automatically changed from alberto/player-disable-expiry-check to main November 5, 2024 15:34
@asendra asendra force-pushed the alberto/offline-privilege-check branch from 24ad51a to fdffacd Compare November 5, 2024 15:43
@asendra asendra mentioned this pull request Nov 5, 2024
Merged
@asendra asendra added this pull request to the merge queue Nov 5, 2024
Merged via the queue into main with commit d7281a4 Nov 5, 2024
5 checks passed
@asendra asendra deleted the alberto/offline-privilege-check branch November 5, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ceciliasaraiva ceciliasaraiva ceciliasaraiva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asendra @ceciliasaraiva