Merge pull request #161 from tidal-music/alberto/offlineengine-hotfix

[Player] OfflineEngine bug with offlinePrivilegeCheck

CHANGELOG.md

@@ -5,6 +5,11 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.3.44] - 2024-11-11
+
+### Fix
+- Fix implementation of `offlinePrivilegeCheck` in PlayerEngine (Player)
+
 ## [0.3.43] - 2024-11-08
 
 ### Removed

Sources/Player/Player.swift

@@ -55,6 +55,7 @@ public final class Player {
 	private let featureFlagProvider: FeatureFlagProvider
 	private var externalPlayersSupplier: (() -> [GenericMediaPlayer.Type])?
 	private let credentialsProvider: CredentialsProvider
+	private let offlinePlaybackPrivilegeCheck: (() -> Bool)?
 
 	// MARK: - Initialization
 
@@ -73,7 +74,8 @@ public final class Player {
 		offlineEngine: OfflineEngine,
 		featureFlagProvider: FeatureFlagProvider,
 		externalPlayersSupplier: (() -> [GenericMediaPlayer.Type])?,
-		credentialsProvider: CredentialsProvider
+		credentialsProvider: CredentialsProvider,
+		offlinePlaybackPrivilegeCheck: (() -> Bool)?
 	) {
 		self.queue = queue
 		playerURLSession = urlSession
@@ -90,6 +92,7 @@ public final class Player {
 		self.featureFlagProvider = featureFlagProvider
 		self.externalPlayersSupplier = externalPlayersSupplier
 		self.credentialsProvider = credentialsProvider
+		self.offlinePlaybackPrivilegeCheck = offlinePlaybackPrivilegeCheck
 	}
 }
 
@@ -203,7 +206,8 @@ public extension Player {
 			notificationsHandler,
 			featureFlagProvider,
 			externalPlayersSupplier,
-			credentialsProvider
+			credentialsProvider,
+			offlinePlaybackPrivilegeCheck
 		)
 
 		shared = Player(
@@ -221,7 +225,8 @@ public extension Player {
 			offlineEngine: offlineEngine,
 			featureFlagProvider: featureFlagProvider,
 			externalPlayersSupplier: externalPlayersSupplier,
-			credentialsProvider: credentialsProvider
+			credentialsProvider: credentialsProvider,
+			offlinePlaybackPrivilegeCheck: offlinePlaybackPrivilegeCheck
 		)
 
 		return shared
@@ -410,7 +415,8 @@ private extension Player {
 			notificationsHandler,
 			featureFlagProvider,
 			externalPlayersSupplier,
-			credentialsProvider
+			credentialsProvider,
+			offlinePlaybackPrivilegeCheck
 		)
 	}
 
@@ -424,9 +430,9 @@ private extension Player {
 		_ playerEventSender: PlayerEventSender,
 		_ notificationsHandler: NotificationsHandler?,
 		_ featureFlagProvider: FeatureFlagProvider,
-		_ externalPlayersSupplier: (() -> [GenericMediaPlayer.Type])? = nil,
+		_ externalPlayersSupplier: (() -> [GenericMediaPlayer.Type])?,
 		_ credentialsProvider: CredentialsProvider,
-		_ offlinePlaybackPrivilegeCheck: (() -> Bool)? = nil
+		_ offlinePlaybackPrivilegeCheck: (() -> Bool)?
 	) -> PlayerEngine {
 		let internalPlayerLoader = InternalPlayerLoader(
 			with: configuration,

Tests/PlayerTests/Player/PlayerTests.swift

@@ -72,7 +72,8 @@ final class PlayerTests: XCTestCase {
 			offlineEngine: offlineEngine,
 			featureFlagProvider: .mock,
 			externalPlayersSupplier: nil,
-			credentialsProvider: CredentialsProviderMock()
+			credentialsProvider: CredentialsProviderMock(),
+			offlinePlaybackPrivilegeCheck: nil
 		)
 	}
 }

version.txt

@@ -1 +1 @@
-0.3.43
+0.3.44