Add generated catalog models #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michpohl
force-pushed
the
michael/Add-generated-catalog-models
branch
from
5f22230 to
ba8d46a
Compare
The following commit will contain generated code that does not at all comply with our lint settings. This commit changes them so it will pass. It's an isolated commit so it can be reversed once we've fixed this in the future
This is an API client generated by openapi-generator-cli Only changes made to this are: - Adding dependencies to our version catalog - Changing package structure to fit with the SDK paradigm This state is temporary.
michpohl
force-pushed
the
michael/Add-generated-catalog-models
branch
from
ba8d46a to
12e663e
Compare
CanYumusak
reviewed
Jun 19, 2024
| /** | ||
| * | ||
| * Please note: | ||
| * This class is auto generated by OpenAPI Generator (https://openapi-generator.tech). |
There was a problem hiding this comment.
The namings of the files are weird (APIApi) - intended?
CanYumusak
reviewed
Jun 19, 2024
|
|
||
| package com.tidal.sdk.catalog.models | ||
|
|
||
| import com.squareup.moshi.Json |
There was a problem hiding this comment.
This is using moshi instead of kotlinx.serialization. Any reason for that?
CanYumusak
reviewed
Jun 19, 2024
| */ | ||
| @Suppress("UNCHECKED_CAST") | ||
| @Throws(IllegalStateException::class, IOException::class) | ||
| fun getArtistWithHttpInfo(id: kotlin.String, countryCode: kotlin.String, include: kotlin.collections.List<kotlin.String>?) : ApiResponse<ArtistDataDocument?> { |
There was a problem hiding this comment.
How come these are not suspend funs?
CanYumusak
reviewed
Jun 19, 2024
|
|
||
| val EMPTY_REQUEST: RequestBody = ByteArray(0).toRequestBody() | ||
|
|
||
| @TargetApi(26) |
There was a problem hiding this comment.
are we cool to raise the app api to 26?
CanYumusak
reviewed
Jun 19, 2024
|
|
||
| val apiKey: MutableMap<String, String> = mutableMapOf() | ||
| val apiKeyPrefix: MutableMap<String, String> = mutableMapOf() | ||
| var username: String? = null |
CanYumusak
reviewed
Jun 19, 2024
| protected const val XML_MEDIA_TYPE = "application/xml" | ||
| protected const val OCTET_MEDIA_TYPE = "application/octet-stream" | ||
|
|
||
| val apiKey: MutableMap<String, String> = mutableMapOf() |
There was a problem hiding this comment.
exposing mutable maps is quite meh, no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds generated catalog code made using
openapi-generator-clifrom our catalog API endpoint definitions.Only changes necessary to make it compile in our codebase have been made (see commit descriptions).
This is a temporary version intended for prototyping. It will be subject to change.
The generated code has a lot of small issues, but if you're looking to use just the types, you'll be fine.
This will also not be released publicly. If you have trouble creating a local release to work with this hit me up, and I'll shoe you how.