Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5 Usage Example for Graphics P1 #340

Open
wants to merge 1 commit into
base: usage-examples
Choose a base branch
from

Conversation

huyhuynh2319
Copy link

Description

This is a usage example of the function to flip, rotate and free fonts

Splashkit Function:
option-flip-x
option-flip-y
option-flip-xy
free-all-fonts
option-rotate-bitmap

Testing Checklist

  • C++ code
  • C# code (top-level statements)
  • C# code (Object-Oriented Programming)
  • Python code
  • Screenshot
  • Title and explanation (.txt)

Usage Example Checks

  • Simple, clear demonstration of the function
  • Code uses Splashkit functions
  • Tested in Chrome and Firefox

Copy link

netlify bot commented Dec 11, 2024

Deploy Preview for splashkit-io ready!

Name Link
🔨 Latest commit 2e509be
🔍 Latest deploy log https://app.netlify.com/sites/splashkit-io/deploys/6758f705fabc760007ff7f72
😎 Deploy Preview https://deploy-preview-340--splashkit-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@huyhuynh2319 huyhuynh2319 changed the base branch from main to usage-examples December 11, 2024 02:23
Copy link

@ShaunR1991 ShaunR1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall a solid usage example submission. There are a few points to address for the PR as a whole before it can be approved.

Naming Conventions

The naming convention of the file names have meant that the script is not generating the usage examples on the page. Refer https://thoth-tech.netlify.app/products/splashkit/splashkit-website/usage-examples/02-creating-usage-examples/

Will need to replace function names with underscores (_) rather than dashes (-)

option-flip-x -> option_flip_x
option-flip-xy -> option_flip_xy
option-flip-y -> option_flip_y
option-rotate-bmp -> option_rotate_bmp

Code Execution

Code executed well without any issues. Comments are consistent throughout each of the examples which is helpful to translate between different languages. A few points for refinement:

free_all_fonts

  • May be worth having something either printing to the window or printing to the console if freeing all fonts was successful or not. It currently just look like the font is disappearing, but what is happening in the backend?

option_flip_y

  • Recommend perhaps using an image that you can more clearly identify a flip over the y axis. You can see the flip happening, but because of the nature of the image it's a little challenging to notice unless you look really closely.

option_rotate_bmp

  • Consider recording a .gif for this one to demonstrate the gradual rotation, rather than a still image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants