Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6 Usage Examples for JSON - Part 2 #332

Open
wants to merge 2 commits into
base: usage-examples
Choose a base branch
from

Conversation

breezy-codes
Copy link

Created JSON functions for json_from_string, json_has_key, json_read_bool, json_read_number, json_read_number_as_double, and json_from_file.

These all show simple ways of using these functions all by creating a json object within the code and then doing the specific function.

Files Included (For all functions)

  • Title and explanation (.txt)
  • C++ code
  • C# code (top-level statements)
  • C# code (Object-Oriented Programming)
  • Python code
  • Screenshot

Usage Example Checks

  • Simple, clear demonstration of the function
  • Code uses Splashkit functions
  • Tested in Chrome and Firefox

Copy link

netlify bot commented Dec 8, 2024

Deploy Preview for splashkit-usage-examples ready!

Name Link
🔨 Latest commit 577e86f
🔍 Latest deploy log https://app.netlify.com/sites/splashkit-usage-examples/deploys/675e5d9f59cee60008f8c836
😎 Deploy Preview https://deploy-preview-332--splashkit-usage-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@EthanRin EthanRin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed the usage examples and most of it seems good with consistent code and clear demonstration of each functions. There are some areas to improve on though:

  • json_has_key C# OOP code is actually CPP please update the file to C#
  • Except json_from_file, I found most of the description to be ambiguous. For instance:
    The following code shows an example of using [json read number as double](/api/json/#json-read-number-as-double) to create a JSON object with a number make it seems like the function is used to create a JSON object.

Copy link

@EthanRin EthanRin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed this usage example and have tested each implementation of the program across different languages.
The code is well-structured and is consistent throughout each implementations. I approved of this PR.

Checklist

  • Code uses SplashKit functions
  • Code demonstrates uses of the functions
  • Python code ran as expected.
  • C# OOP code ran as expected.
  • C# Top Level code ran as expected
  • C++ Code ran as expected

Files required

  • Python code
  • C# OOP code
  • C# Top Level code
  • C++ Code
  • Screenshot of the program running
  • Title and description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants