Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing logic to fix due_date extension #45

Open
wants to merge 1 commit into
base: 8.0.x
Choose a base branch
from

Conversation

Shounaks
Copy link

@Shounaks Shounaks commented Nov 22, 2024

Description

new feature - adjust the automatic extension on "resubmit" being awarded to be one week from the date of the feedback

Working on previous commits; #9

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested on Local by Deploying whole application and then ensuring that the whole feature works end-to-end.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if appropriate
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have created or extended unit tests to address my new additions
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

If you have any questions, please contact @macite or @jakerenzella.

Before Change

--TO BE ADDED

After Change:

Before setting the status to Fix and Resubmit
image
After setting the status to Fix and Resubmit
image

Copy link

@s223552468 s223552468 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi the logic is correct and the code is working fine as the due data is being extended
Screenshot 2024-11-29 144406
Screenshot 2024-11-29 145403
I approve all the changes !,Good work @Shounaks

@DudeUnleashed
Copy link

The code additions work as intended to extend the due date if a task is marked as fix and resubmit. The logic makes sense to keep original functionality as well if there is no extensions remaining.
Tested and shown working. Good work @Shounaks

Copy link

@Ashdeore Ashdeore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before code changes screenshots

1 before

Screenshot for changes made in code
2

Screenshot for final changes in a code and successfully resubmit changes.

3

Great job, @Shounaks The code is working perfectly as intended. The before-and-after screenshots clearly highlight the improvements, showing the impact of your updates. Your attention to detail and dedication are impressive well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants