fix: ensure we can get the report url for moss reports

thoth-tech · Jan 7, 2024 · 582d13a · 582d13a
1 parent 984524f
commit 582d13a
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/app/api/entities/task_definition_entity.rb b/app/api/entities/task_definition_entity.rb
@@ -34,7 +34,6 @@ def staff?(my_role)
       task_definition.tutorial_stream.abbreviation unless task_definition.tutorial_stream.nil?
     end
     expose :plagiarism_checks, if: ->(unit, options) { staff?(options[:my_role]) }
-    expose :plagiarism_report_url, if: ->(unit, options) { staff?(options[:my_role]) }
     expose :plagiarism_warn_pct, if: ->(unit, options) { staff?(options[:my_role]) }
     expose :restrict_status_updates, if: ->(unit, options) { staff?(options[:my_role]) }
     expose :group_set_id

diff --git a/app/api/similarity/task_similarity_api.rb b/app/api/similarity/task_similarity_api.rb
@@ -116,7 +116,7 @@ class TaskSimilarityApi < Grape::API
           error!({ error: "Similarity report is not yet ready to be viewed for this submission" }, 404)
         end
       else
-        error!({ error: "No details to download for task '#{params[:id]}'" }, 404)
+        similarity.plagiarism_report_url
       end
     end
   end
-Original file line number
+Diff line change
@@ Expand Up / @@ -116,7 +116,7 @@ class TaskSimilarityApi < Grape::API @@
               error!({ error: "Similarity report is not yet ready to be viewed for this submission" }, 404)
             end
           else
-            error!({ error: "No details to download for task '#{params[:id]}'" }, 404)
+            similarity.plagiarism_report_url
           end
         end
       end
@@ Expand Down @@