Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Packages #5921

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Version Packages #5921

wants to merge 1 commit into from

Conversation

jnsdls
Copy link
Member

@jnsdls jnsdls commented Jan 9, 2025

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

thirdweb@5.83.2

Patch Changes

  • #5926 4b5661b Thanks @MananTank! - Export toEventSelector utility function from "thirdweb/utils"

  • #5923 42a313f Thanks @kumaryash90! - Fix deploy version for published contracts

  • #5924 7fb5ce1 Thanks @joaquim-verges! - Ensure resetting deploy flag on bundler errors

  • #5937 0e2b3df Thanks @MananTank! - Add isValidENSName utility function for checking if a string is a valid ENS name. It does not check if the name is actually registered, it only checks if the string is in a valid format.

    import { isValidENSName } from "thirdweb/utils";
    
    isValidENSName("thirdweb.eth"); // true
    isValidENSName("foo.bar.com"); // true
    isValidENSName("foo"); // false
  • #5914 c5c6f9d Thanks @MananTank! - Do not prompt user for signing message for SIWE auth in Connect UI for Ecosystem wallets

@thirdweb-dev/wagmi-adapter@0.1.8


PR-Codex overview

This PR updates the version numbers for the thirdweb and @thirdweb-dev/wagmi-adapter packages, adds a new changelog entry for thirdweb version 5.83.2, and includes several bug fixes and utility function exports.

Detailed summary

  • Updated thirdweb version from 5.83.1 to 5.83.2
  • Updated @thirdweb-dev/wagmi-adapter version from 0.1.7 to 0.1.8
  • Added changelog for thirdweb version 5.83.2 with:
    • Export of toEventSelector utility function
    • Fix for deploy version of published contracts
    • Resetting deploy flag on bundler errors
    • Added isValidENSName utility function for validating ENS names
    • Prevented prompt for signing message for SIWE auth in Connect UI for Ecosystem wallets

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@jnsdls jnsdls requested review from a team as code owners January 9, 2025 20:42
Copy link

vercel bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 0:08am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 0:08am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 0:08am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 0:08am

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Jan 9, 2025
Copy link

graphite-app bot commented Jan 9, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link
Contributor

github-actions bot commented Jan 9, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.65 KB (0%) 913 ms (0%) 3 s (-18.68% 🔽) 3.9 s
thirdweb (cjs) 115.43 KB (0%) 2.4 s (0%) 6.4 s (+22.51% 🔺) 8.7 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 405 ms (+20.33% 🔺) 517 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 120 ms (+227% 🔺) 130 ms
thirdweb/react (minimal + tree-shaking) 19.21 KB (0%) 385 ms (0%) 604 ms (+10.06% 🔺) 989 ms

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.85%. Comparing base (23d8001) to head (11bbe8f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5921   +/-   ##
=======================================
  Coverage   54.85%   54.85%           
=======================================
  Files        1142     1142           
  Lines       60928    60928           
  Branches     5140     5142    +2     
=======================================
  Hits        33424    33424           
  Misses      26777    26777           
  Partials      727      727           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 23d8001
packages 52.50% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant