-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dashboard] Feature: UI for crosschain modules #5399
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5399 +/- ##
========================================
Coverage 51.21% 51.22%
========================================
Files 1092 1092
Lines 57336 57454 +118
Branches 4674 4693 +19
========================================
+ Hits 29364 29429 +65
- Misses 27256 27309 +53
Partials 716 716
*This pull request uses carry forward flags. Click here to find out more.
|
size-limit report 📦
|
@GWSzeto could you reference a linear ticket in the description |
apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/cross-chain/page.tsx
Outdated
Show resolved
Hide resolved
const { contract } = info; | ||
|
||
if (contract.chain.id === localhost.id) { | ||
return <div>asd</div>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace the placeholder asd
with a descriptive message that communicates the localhost limitation to users, such as Cross-chain deployment is not available on localhost networks
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
This PR has been inactive for 30 days. It is now marked as stale and will be closed in 5 days if no further activity occurs. |
This PR has been inactive for 7 days. It is now marked as stale and will be closed in 2 days if no further activity occurs. |
https://linear.app/thirdweb/project/[modular-contracts]-op-interoperability-module-87740e1390a9/overview
PR-Codex overview
This PR focuses on enhancing the functionality and usability of a dashboard application by introducing cross-chain capabilities, refining contract deployment processes, and improving code organization and readability.
Detailed summary
Cross Chain
option in sidebar links.showSuperchainBridgeFieldset
function.modifiedProxyDeployedEvent
function for event handling.nonce
parameter toinstallPublishedModule
options.CROSS_CHAIN
data structure inexplore.ts
.proxyDeployedEvent
withmodifiedProxyDeployedEvent
in deployment logic.deployViaAutoFactoryWithImplementationParams
function for improved deployment.DataTable
.