Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language support: Hindi #3866

Closed
wants to merge 1 commit into from
Closed

Add language support: Hindi #3866

wants to merge 1 commit into from

Conversation

kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Jul 29, 2024

PR-Codex overview

This PR adds support for the Hindi language (hi_IN) in wallet localization across various modules.

Detailed summary

  • Added Hindi language support (hi_IN) in wallet localization for various modules.
  • Updated LocaleId type to include "hi_IN".
  • Added Hindi translations for wallet screens, instructions, and buttons.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 10:11pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 10:11pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 10:11pm

Copy link

changeset-bot bot commented Jul 29, 2024

⚠️ No Changeset found

Latest commit: 2af240a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

graphite-app bot commented Jul 29, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the TS SDK Involves changes to the v5 TypeScript SDK. label Jul 29, 2024
@graphite-app graphite-app bot requested a review from jnsdls July 29, 2024 21:54
Copy link

graphite-app bot commented Jul 29, 2024

Graphite Automations

"If PR for SDK -> Tag Joaquim, Jonas and Greg" took an action on this PR • (07/29/24)

1 reviewer was added to this PR based on Kien Ngo's automation.

Copy link

codspeed-hq bot commented Jul 29, 2024

CodSpeed Performance Report

Merging #3866 will degrade performances by 11.31%

Comparing kien/add-hindi (2af240a) with main (7ec421f)

Summary

❌ 1 regressions
✅ 8 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main kien/add-hindi Change
keccakId 1.3 ms 1.5 ms -11.31%

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43.16 KB (0%) 864 ms (0%) 758 ms (+14.36% 🔺) 1.7 s
thirdweb (cjs) 91.37 KB (0%) 1.9 s (0%) 1.8 s (+46.71% 🔺) 3.6 s
thirdweb (minimal + tree-shaking) 4.79 KB (0%) 96 ms (0%) 52 ms (-18.91% 🔽) 147 ms
thirdweb/chains (tree-shaking) 492 B (0%) 10 ms (0%) 26 ms (+170.42% 🔺) 36 ms
thirdweb/react (minimal + tree-shaking) 13.62 KB (0%) 273 ms (0%) 170 ms (+99.58% 🔺) 443 ms

@MananTank
Copy link
Member

MananTank commented Jul 29, 2024

imo, Adding Hindi is not required. Hindi speakers on the internet already know English and prefer the UI to be in English.

@kien-ngo
Copy link
Contributor Author

@MananTank im completely ignorant to that fact lol. Was gonna have Yash help me on this but alright

(this PR can still be used as a template in case external contributor want to add another language i guess)

@kien-ngo kien-ngo marked this pull request as draft July 29, 2024 22:02
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 61.55%. Comparing base (77b852a) to head (2af240a).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3866      +/-   ##
==========================================
+ Coverage   61.47%   61.55%   +0.07%     
==========================================
  Files         962      963       +1     
  Lines       76560    76677     +117     
  Branches     3786     3818      +32     
==========================================
+ Hits        47064    47195     +131     
+ Misses      28813    28797      -16     
- Partials      683      685       +2     
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 77b852a
packages 60.86% <0.00%> (+0.09%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...wallets/injected/locale/getInjectedWalletLocale.ts 25.00% <0.00%> (-2.28%) ⬇️
...eact/web/wallets/shared/locale/getConnectLocale.ts 25.00% <0.00%> (-2.28%) ⬇️
...wallets/smartWallet/locale/getSmartWalletLocale.ts 25.00% <0.00%> (-2.28%) ⬇️
...ct/web/ui/ConnectWallet/locale/getConnectLocale.ts 61.53% <0.00%> (-5.13%) ⬇️

... and 7 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TS SDK Involves changes to the v5 TypeScript SDK.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants