-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add language support: Hindi #3866
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Your org requires the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Graphite Automations"If PR for SDK -> Tag Joaquim, Jonas and Greg" took an action on this PR • (07/29/24)1 reviewer was added to this PR based on Kien Ngo's automation. |
CodSpeed Performance ReportMerging #3866 will degrade performances by 11.31%Comparing Summary
Benchmarks breakdown
|
size-limit report 📦
|
imo, Adding Hindi is not required. Hindi speakers on the internet already know English and prefer the UI to be in English. |
@MananTank im completely ignorant to that fact lol. Was gonna have Yash help me on this but alright (this PR can still be used as a template in case external contributor want to add another language i guess) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3866 +/- ##
==========================================
+ Coverage 61.47% 61.55% +0.07%
==========================================
Files 962 963 +1
Lines 76560 76677 +117
Branches 3786 3818 +32
==========================================
+ Hits 47064 47195 +131
+ Misses 28813 28797 -16
- Partials 683 685 +2
*This pull request uses carry forward flags. Click here to find out more.
|
PR-Codex overview
This PR adds support for the Hindi language (
hi_IN
) in wallet localization across various modules.Detailed summary
hi_IN
) in wallet localization for various modules.LocaleId
type to include "hi_IN".