Prebuilt UI: BuyDirectListingButton for Marketplace v3 #3847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: e27ebef The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Your org requires the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Graphite Automations"If PR for SDK -> Tag Joaquim, Jonas and Greg" took an action on this PR • (07/27/24)3 reviewers were added to this PR based on Kien Ngo's automation. |
CodSpeed Performance ReportMerging #3847 will not alter performanceComparing Summary
|
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3847 +/- ##
==========================================
+ Coverage 61.52% 61.57% +0.05%
==========================================
Files 963 964 +1
Lines 76668 76869 +201
Branches 3812 3822 +10
==========================================
+ Hits 47171 47335 +164
- Misses 28814 28849 +35
- Partials 683 685 +2
*This pull request uses carry forward flags. Click here to find out more.
|
|
/release-pr |
jnsdls
reviewed
Jul 28, 2024
packages/thirdweb/src/react/web/ui/prebuilt/thirdweb/BuyButton/index.tsx
Outdated
Show resolved
Hide resolved
kien-ngo
changed the title
packages/thirdweb/src/react/web/ui/prebuilt/thirdweb/BuyDirectListingButton/index.tsx
Show resolved
Hide resolved
packages/thirdweb/src/react/web/ui/prebuilt/thirdweb/BuyDirectListingButton/index.tsx
Outdated
Show resolved
Hide resolved
joaquim-verges
approved these changes
Jul 29, 2024
Merge activity
|
kien-ngo
added a commit
that referenced
this pull request
Jul 29, 2024
<!-- start pr-codex -->
## PR-Codex overview
This PR adds a new prebuilt component `BuyDirectListingButton` for Marketplace v3 in Thirdweb.
### Detailed summary
- Added `BuyDirectListingButton` component for buying NFTs in Marketplace v3
- Updated related tests and utility functions
- Improved documentation for the new component
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
kien-ngo
force-pushed
the
kien/ui/buybutton
branch
from
8832847 to
1bc74ff
Compare
kien-ngo
added a commit
that referenced
this pull request
Jul 29, 2024
<!-- start pr-codex -->
## PR-Codex overview
This PR adds a new prebuilt component `BuyDirectListingButton` for Marketplace v3. It includes the button logic for buying NFTs from a listing.
### Detailed summary
- Added `BuyDirectListingButton` component for Marketplace v3
- Implemented button logic for buying NFTs from a listing
- Included tests for `BuyDirectListingButton`
- Defined props and functionality for `BuyDirectListingButton`
- Created transaction handling for purchasing NFTs
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
kien-ngo
force-pushed
the
kien/ui/buybutton
branch
from
1bc74ff to
9624687
Compare
kien-ngo
added a commit
that referenced
this pull request
Jul 29, 2024
<!-- start pr-codex -->
## PR-Codex overview
This PR adds a new prebuilt component `BuyDirectListingButton` for Marketplace v3 in Thirdweb.
### Detailed summary
- Added `BuyDirectListingButton` component for buying NFTs in Marketplace v3
- Included tests for `BuyDirectListingButton`
- Created functionality to prepare and execute buy transactions
- Integrated with `TransactionButton` for transaction handling
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
kien-ngo
force-pushed
the
kien/ui/buybutton
branch
from
9624687 to
88b3fa3
Compare
<!-- start pr-codex -->
## PR-Codex overview
This PR adds a new prebuilt component `BuyDirectListingButton` for Marketplace v3 in Thirdweb.
### Detailed summary
- Added `BuyDirectListingButton` component for buying NFTs from a listing
- Includes necessary logic for preparing and executing transactions
- Provides detailed documentation and testing for the component
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
kien-ngo
force-pushed
the
kien/ui/buybutton
branch
from
88b3fa3 to
e27ebef
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR adds a new prebuilt component
BuyDirectListingButtonfor Marketplace v3 in Thirdweb.Detailed summary
BuyDirectListingButtoncomponent for buying NFTs from a listingTransactionButtonfor transaction handling