Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alpha #2154

Closed
wants to merge 3 commits into from
Closed

alpha #2154

wants to merge 3 commits into from

Conversation

jnsdls
Copy link
Member

@jnsdls jnsdls commented Jan 11, 2024

No description provided.

@jnsdls jnsdls added the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Jan 11, 2024
@jnsdls jnsdls requested a review from a team as a code owner January 11, 2024 11:24
@jnsdls jnsdls requested review from a team January 11, 2024 11:24
Copy link

changeset-bot bot commented Jan 11, 2024

⚠️ No Changeset found

Latest commit: 4a03d61

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jnsdls jnsdls marked this pull request as draft January 11, 2024 11:24
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (beta@6cbff02). Click here to learn what that means.

❗ Current head 76d48ae differs from pull request most recent head 4a03d61. Consider uploading reports for the commit 4a03d61 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             beta    #2154   +/-   ##
=======================================
  Coverage        ?   27.11%           
=======================================
  Files           ?      672           
  Lines           ?    47554           
  Branches        ?     1961           
=======================================
  Hits            ?    12893           
  Misses          ?    34018           
  Partials        ?      643           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

socket-security bot commented Feb 7, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

Copy link

socket-security bot commented Feb 13, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@changesets/cli@2.27.1 environment, filesystem, shell Transitive: eval, unsafe +299 28.5 MB changesets-release-bot
npm/@coinbase/wallet-sdk@3.7.2 Transitive: environment, eval, filesystem, network, shell +117 33.9 MB coinbase-jake
npm/@emotion/react@11.11.3 environment Transitive: filesystem, unsafe +60 7.82 MB emotion-release-bot
npm/@manypkg/cli@0.21.2 environment, filesystem Transitive: eval, network, shell +108 3.3 MB manypkg-release-bot
npm/@size-limit/preset-big-lib@11.0.2 Transitive: environment, eval, filesystem, network, shell, unsafe +204 41.1 MB ai
npm/@tanstack/eslint-plugin-query@5.20.1 Transitive: environment, eval, filesystem, shell, unsafe +128 46.5 MB tannerlinsley
npm/@tanstack/react-query@5.22.2 Transitive: environment +4 4.08 MB nksaraf, tannerlinsley
npm/@trivago/prettier-plugin-sort-imports@4.3.0 Transitive: environment, filesystem, unsafe +41 22.4 MB behraang
npm/@types/bun@1.0.6 None +5 8.34 MB types
npm/@types/node@18.19.18 None +1 3.96 MB types
npm/@viem/anvil@0.0.7 network Transitive: environment, filesystem, shell +27 1.73 MB awkweb
npm/@vitest/coverage-v8@1.3.1 Transitive: environment, filesystem, network, shell, unsafe +117 24.7 MB antfu, oreanno, patak, ...1 more
npm/@walletconnect/ethereum-provider@2.11.1 Transitive: environment, eval, filesystem, network, shell, unsafe +231 42.5 MB gancho_walletconnect
npm/abitype@1.0.0 None +2 33.8 MB awkweb
npm/dotenv-mono@1.3.13 environment, filesystem +2 154 kB marcocesarato
npm/eslint-plugin-jsdoc@48.1.0 filesystem Transitive: environment, eval, shell, unsafe +112 13.6 MB gajus
npm/ethers@6.11.1 network +7 19.6 MB ricmoo
npm/knip@5.0.1 environment, filesystem, shell, unsafe Transitive: network +222 48 MB webpro
npm/mipd@0.0.5 Transitive: environment, network +13 43.7 MB jmoxey
npm/mocha@10.3.0 environment, eval, filesystem +71 4.92 MB joshuakgoldberg
npm/prettier@3.2.5 environment, filesystem, unsafe 0 8.39 MB prettier-bot
npm/rimraf@5.0.5 environment, filesystem Transitive: shell +34 3.22 MB isaacs
npm/size-limit@11.0.2 Transitive: environment, filesystem +34 831 kB ai
npm/turbo@1.12.4 None 0 30.6 kB turbobot
npm/typedoc@0.25.7 Transitive: environment, filesystem, network +11 52 MB typedoc-bot
npm/uqr@0.1.2 None 0 72 kB antfu
npm/viem@2.7.11 Transitive: environment, network +12 45.5 MB awkweb, jmoxey
npm/vitest@1.3.1 Transitive: environment, filesystem, network, shell, unsafe +74 16.2 MB antfu, oreanno, patak, ...1 more

🚮 Removed packages: npm/@changesets/cli@2.26.2, npm/@manypkg/cli@0.21.0, npm/@trivago/prettier-plugin-sort-imports@4.2.0, npm/@vitejs/plugin-react@2.2.0, npm/react-scripts@5.0.1, npm/serve@14.2.0, npm/turbo@1.11.3, npm/typedoc@0.25.2, npm/vite-plugin-node-polyfills@0.7.0

View full report↗︎

@jxom
Copy link
Contributor

jxom commented Feb 27, 2024

I am curious if the benchmarks bust the LRU caches per iteration (or iterations are not pure) to reflect a fair and real world comparison?

Update: we added this to isAddress recently, but just realised we didn’t update benchmarks to reflect - we can update that on our side.

@jnsdls jnsdls changed the base branch from main to beta February 27, 2024 17:53
@jnsdls
Copy link
Member Author

jnsdls commented Feb 28, 2024

we're #2356 now

@jnsdls jnsdls closed this Feb 28, 2024
@jnsdls
Copy link
Member Author

jnsdls commented Feb 28, 2024

I am curious if the benchmarks bust the LRU caches per iteration (or iterations are not pure) to reflect a fair and real world comparison?

Update: we added this to isAddress recently, but just realised we didn’t update benchmarks to reflect - we can update that on our side.

this is something I need to take a look at, good shout. We'll definitely want to do it (at least in the) "cold cache" benches

@jnsdls jnsdls deleted the alpha branch April 2, 2024 02:09
@jnsdls jnsdls restored the alpha branch April 2, 2024 02:09
@jnsdls jnsdls deleted the alpha branch April 2, 2024 02:09
jnsdls pushed a commit that referenced this pull request Jun 19, 2024
Bumps [@stripe/react-stripe-js](https://github.com/stripe/react-stripe-js) from 2.3.2 to 2.4.0.
- [Release notes](https://github.com/stripe/react-stripe-js/releases)
- [Changelog](https://github.com/stripe/react-stripe-js/blob/master/CHANGELOG.md)
- [Commits](stripe/react-stripe-js@v2.3.2...v2.4.0)

---
updated-dependencies:
- dependency-name: "@stripe/react-stripe-js"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Nacho Iacovino <nacho.iacovino@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE This pull request is still in progress and is not ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants