fix(gas): correct gas estimation logic on Arbitrum Sepolia

thirdweb-dev · Jul 24, 2024 · b2858a0 · b2858a0
1 parent c82c524
commit b2858a0
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 3 deletions.
diff --git a/.changeset/dull-vans-kneel.md b/.changeset/dull-vans-kneel.md
@@ -0,0 +1,5 @@
+---
+"thirdweb": patch
+---
+
+Fix gas estimation on arbitrum sepolia
diff --git a/packages/thirdweb/src/gas/fee-data.ts b/packages/thirdweb/src/gas/fee-data.ts
@@ -107,7 +107,10 @@ export async function getDefaultGasOverrides(
   // if chain is in the force gas price list, always use gas price
   if (!FORCE_GAS_PRICE_CHAIN_IDS.includes(chain.id)) {
     const feeData = await getDynamicFeeData(client, chain);
-    if (feeData.maxFeePerGas && feeData.maxPriorityFeePerGas) {
+    if (
+      feeData.maxFeePerGas !== null &&
+      feeData.maxPriorityFeePerGas !== null
+    ) {
       return {
         maxFeePerGas: feeData.maxFeePerGas,
         maxPriorityFeePerGas: feeData.maxPriorityFeePerGas,
@@ -153,12 +156,12 @@ async function getDynamicFeeData(
   if (chainId === 80002 || chainId === 137) {
     // for polygon, get fee data from gas station
     maxPriorityFeePerGas_ = await getPolygonGasPriorityFee(chainId);
-  } else if (maxPriorityFeePerGas) {
+  } else if (maxPriorityFeePerGas !== null) {
     // prioritize fee from eth_maxPriorityFeePerGas
     maxPriorityFeePerGas_ = maxPriorityFeePerGas;
   }
 
-  if (!maxPriorityFeePerGas_) {
+  if (maxPriorityFeePerGas_ == null) {
     // chain does not support eip-1559, return null for both
     return { maxFeePerGas: null, maxPriorityFeePerGas: null };
   }

diff --git a/packages/thirdweb/src/transaction/actions/to-serializable-transaction.test.ts b/packages/thirdweb/src/transaction/actions/to-serializable-transaction.test.ts
@@ -4,6 +4,8 @@ import { TEST_WALLET_B } from "../../../test/src/addresses.js";
 import { FORKED_ETHEREUM_CHAIN } from "../../../test/src/chains.js";
 import { TEST_CLIENT } from "../../../test/src/test-clients.js";
 
+import { arbitrumSepolia } from "../../chains/chain-definitions/arbitrum-sepolia.js";
+import { ZERO_ADDRESS } from "../../constants/addresses.js";
 import { toWei } from "../../utils/units.js";
 import {
   type PreparedTransaction,
@@ -400,4 +402,18 @@ describe("toSerializableTransaction", () => {
       ).not.toThrow();
     });
   });
+
+  test("should respect 0 maxPriorityFeePerGas chains", async () => {
+    const serializableTransaction = await toSerializableTransaction({
+      transaction: prepareTransaction({
+        to: TEST_WALLET_B,
+        chain: arbitrumSepolia,
+        value: toWei("0.000001"),
+        client: TEST_CLIENT,
+      }),
+      from: ZERO_ADDRESS,
+    });
+
+    expect(serializableTransaction.gasPrice).toBe(null);
+  });
 });