fix(utils): cancel fetch request if response is not ok

thirdweb-dev · Feb 27, 2024 · 0060e4b · 0060e4b
1 parent 928eec4
commit 0060e4b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/packages/thirdweb/src/chains/utils.ts b/packages/thirdweb/src/chains/utils.ts
@@ -205,6 +205,7 @@ export function getChainDataForChain(chain: Chain): Promise<ApiChain> {
     async () => {
       const res = await fetch(`https://api.thirdweb.com/v1/chains/${chainId}`);
       if (!res.ok) {
+        res.body?.cancel();
         throw new Error(`Failed to fetch chain data for chainId ${chainId}`);
       }
 

diff --git a/packages/thirdweb/src/utils/signatures/resolve-signature.ts b/packages/thirdweb/src/utils/signatures/resolve-signature.ts
@@ -17,6 +17,7 @@ async function resolveFunctionSignature(
     `${SIGNATURE_API}/signatures/?format=json&hex_signature=${hexSig}`,
   );
   if (!res.ok) {
+    res.body?.cancel();
     console.log(res.statusText);
     return null;
   }
@@ -39,6 +40,7 @@ async function resolveEventSignature(
     `${SIGNATURE_API}/event-signatures/?format=json&hex_signature=${hexSig}`,
   );
   if (!res.ok) {
+    res.body?.cancel();
     console.log(res.statusText);
     return null;
   }