add queryable extension to ERC721Base #560
Conversation
| * @title ERC721A Queryable | ||
| * @dev ERC721A subclass with convenience query functions. | ||
| */ | ||
| abstract contract ERC721AQueryable is ERC721A, IERC721AQueryable { |
There was a problem hiding this comment.
don't we already have this file somewhere?
There was a problem hiding this comment.
don't we already have this file somewhere?
There isn't a non-upgradable version currently.
ERC721Base has 13kb in left over space. The queryable adds ~1kb. |
|
Should be plenty. Ship it |
Signed-off-by: WhiteOakKong <92236155+WhiteOakKong@users.noreply.github.com>
|
@nkrishang @kumaryash90 can you review? |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #560 +/- ##
==========================================
- Coverage 62.34% 57.43% -4.91%
==========================================
Files 216 215 -1
Lines 6647 6614 -33
==========================================
- Hits 4144 3799 -345
- Misses 2503 2815 +312 ☔ View full report in Codecov by Sentry. |
No description provided.