Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BTT BurnToClaimDropERC721 and extensions #509

Merged
merged 38 commits into from
Oct 16, 2023

Conversation

kumaryash90
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
contracts/extension/BurnToClaim.sol 100.00% <100.00%> (+100.00%) ⬆️
contracts/extension/Drop.sol 100.00% <ø> (+10.00%) ⬆️
contracts/extension/Drop1155.sol 90.32% <ø> (ø)
contracts/extension/DropSinglePhase.sol 92.85% <ø> (ø)
contracts/extension/DropSinglePhase1155.sol 97.82% <ø> (ø)
contracts/extension/upgradeable/Drop.sol 96.96% <ø> (+9.09%) ⬆️

... and 59 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@kumaryash90 kumaryash90 changed the title Retrospective: tests for BurnToClaimDropERC721 and extensions BTT BurnToClaimDropERC721 and extensions Oct 16, 2023
@kumaryash90 kumaryash90 enabled auto-merge October 16, 2023 21:58
@kumaryash90 kumaryash90 disabled auto-merge October 16, 2023 21:58
@kumaryash90 kumaryash90 enabled auto-merge (squash) October 16, 2023 23:15
@kumaryash90 kumaryash90 merged commit 987c765 into main Oct 16, 2023
6 checks passed
@kumaryash90 kumaryash90 deleted the yash/retrospective-burn-to-claim branch October 16, 2023 23:27
WhiteOakKong added a commit to WhiteOakKong/tw-contracts that referenced this pull request Oct 30, 2023
* test verifyBurnToClaim

* Fix [Q-2] Missing sanity check when setting BurnToClaimInfo

* test setBurnToClaimInfo

* fix tests

* test _burnTokensOnOrigin

* test _burnTokensOnOrigin

* test verifyClaim

* test wallet random

* test setClaimConditions

* test getActiveClaimConditionId

* make verifyClaim virtual

* test claim

* test setContractURI

* update as per latest audit for burn-to-claim

* test royalty extension

* test ownable extension

* test delayed-reveal extension

* test batch-mint-metadata extension

* test lazy-mint extension

* test initialize burn-to-claim

* test other functions burn-to-claim

* test lazyMint main contract

* test burnAndClaim main contract

* test reveal main contract

* other function tests

* mark checked

* other function tests

* fix

* fix

---------

Co-authored-by: Krishang <krishang@thirdweb.com>
Co-authored-by: Joaquim Verges <joaquim.verges@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants