Skip to content

clean natspec and comments on AccountCore #1871

clean natspec and comments on AccountCore

clean natspec and comments on AccountCore #1871

Triggered via pull request October 16, 2023 20:49
Status Failure
Total duration 1m 27s
Artifacts
This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

lint.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

5 errors and 10 warnings
lint: contracts/prebuilts/account/utils/AccountCore.sol#L207
Replace ⏎········bytes·calldata·data with bytes·calldata·data)
lint: contracts/prebuilts/account/utils/AccountCore.sol#L209
Replace )·internal·pure·returns·(address[]·memory·_targets,·uint256[]·memory·_values,·bytes[]·memory·_callData) with ····internal⏎········pure⏎········returns·(⏎············address[]·memory·_targets,⏎············uint256[]·memory·_values,⏎············bytes[]·memory·_callData⏎········)⏎···
lint: contracts/prebuilts/account/utils/AccountCore.sol#L216
Replace ⏎········UserOperation·calldata·userOp,⏎········bytes32·userOpHash with UserOperation·calldata·userOp,·bytes32·userOpHash)
lint: contracts/prebuilts/account/utils/AccountCore.sol#L219
Replace )·internal·virtual·override·returns·(uint256·validationData) with ····internal⏎········virtual⏎········override⏎········returns·(uint256·validationData)⏎···
lint
Process completed with exit code 1.
lint: contracts/eip/ERC721A.sol#L347
Provide an error message for revert
lint: contracts/eip/ERC721AUpgradeable.sol#L385
Provide an error message for revert
lint: contracts/eip/ERC721AVirtualApprove.sol#L349
Provide an error message for revert
lint: contracts/eip/ERC721AVirtualApproveUpgradeable.sol#L360
Provide an error message for revert
lint: contracts/eip/queryable/ERC721A__InitializableStorage.sol#L23
Avoid to use letters 'I', 'l', 'O' as identifiers
lint: contracts/eip/queryable/ERC721AStorage.sol#L51
Avoid to use letters 'I', 'l', 'O' as identifiers
lint: contracts/extension/BurnToClaim.sol#L33
Provide an error message for require
lint: contracts/extension/BurnToClaim.sol#L37
Provide an error message for require
lint: contracts/extension/BurnToClaim.sol#L38
Provide an error message for require
lint: contracts/extension/OperatorFiltererUpgradeable.sol#L12
Explicitly mark visibility of state