Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preflight handling for custom web image #332

Merged
merged 8 commits into from
Jan 16, 2024
Merged

Conversation

jayjb
Copy link
Contributor

@jayjb jayjb commented Jan 16, 2024

Proposed changes

We have added support recently for CORS, except in some cases there is a CORS preflight request. You can read more about it here. We need to handle it appropriately to continue.

Types of changes

What types of changes does your code introduce to this repository?
Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Lint and unit tests pass locally with my changes (if applicable)
  • I have run pre-commit (pre-commit in the repo)
  • I have added tests that prove my fix is effective or that my feature works
  • Linked to the relevant github issue or github discussion (Enable wildcard CORS support #329)

@jayjb jayjb merged commit 27525f5 into master Jan 16, 2024
2 checks passed
@jayjb jayjb deleted the add_preflight_handling branch January 16, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants