-
-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimize Root Processes #167
Minimize Root Processes #167
Conversation
b6223de
to
e0d4e6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested it, and everything works fine, however this is a big PR that I would also like a second opinion on. Posting this in the discord, hopefully someone else would be able to look at it.
Once again thank you for all the contributions :D
LGTM Maybe eventually we can go for non root when we run steam non root (if that is even possible) |
…ocesses Minimize Root Processes
Context
Currently you start the container as root and during the start up process everything is ran as root except the command with
su
.Currently when backups are created they are created and owned by root however on next boot the permission is changed to steam:steam
When starting with a PUID or PGID that is not 1000 you get the following error:
/tmp/dumps is not owned by us - delete and recreate
Choices
su
to start.shTest instructions
Unless explicitly stated your PUID or PGID should not be 0 for testing
/tmp/dumps is not owned by us - delete and recreate
docker exec palworld-server bash -c "ls -ll /home/steam"
docker exec -t palworld-server top
docker exec palworld-server bash -c "backup && ls -l /palworld/backups/"
docker exec -u steam palworld-server bash -c "backup && ls -l /palworld/backups/"
docker exec -it palworld-server-test rcon-cli
docker exec -it -u steam palworld-server-test rcon-cli
/tmp/dumps is not owned by us - delete and recreate
when:Running as root is not supported, please fix your PUID and PGID!
when:Checklist before requesting a review