modify deployment and chart for opionated deployment #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thijsvanloef
added
help wanted
|
Hi @Mercwri Thanks for taking the time to create this PR, i've marked it "help wanted" as I am currently not able to test it myself |
Filipe-Souza
suggested changes
Jan 27, 2024
Filipe-Souza
approved these changes
Jan 28, 2024
MusclePr
pushed a commit
to MusclePr/palworld-server-docker
that referenced
this pull request
Jun 19, 2024
…ication modify deployment and chart for opionated deployment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
It is relatively unsafe with the way Palworld handles it's server terminations to leave the default deployment setting of RollingUpdate. Switching to Recreate ensures the old pod is terminated and not writting to the volume while the new pod is starting.
Choices
Opionated change is done in the suggested deployment yaml and the chart sets Recreate by default but leave it a configurable option.
Test instructions
Deployed to my local cluster, valiadate that deployment still works and that it terminates the pod prior to scheduling the new pod.
Checklist before requesting a review