Add cron command for DockerFile #101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, I will check it once I get home from work! |
thijsvanloef
requested changes
Jan 25, 2024
thijsvanloef
requested changes
Jan 25, 2024
thijsvanloef
changed the title
thijsvanloef
requested changes
Jan 25, 2024
Dockerfile
Outdated
| @@ -5,12 +5,17 @@ RUN apt-get update && apt-get install -y --no-install-recommends \ | |||
| xdg-user-dirs=0.17-2 \ | |||
| procps=2:3.3.17-5 \ | |||
| wget=1.21-1+deb11u1 \ | |||
| && apt-get install -y cron \ | |||
There was a problem hiding this comment.
this is already a list of packages to install, please just use cron=<version>
Dockerfile
Outdated
| TZ=UTC | ||
| TZ=UTC \ | ||
| BACKUP_ENABLED=true \ | ||
| DAYS_TO_KEEP=7 \ |
There was a problem hiding this comment.
Would preferably set this to "BACKUPS_TO_KEEP" and not days
docker-compose.yml
Outdated
| @@ -17,6 +17,9 @@ services: | |||
| - TZ=UTC | |||
| - ADMIN_PASSWORD="adminPasswordHere" | |||
| - COMMUNITY=false # Enable this if you want your server to show up in the community servers tab, USE WITH SERVER_PASSWORD! | |||
| - BACKUP_ENABLED=false | |||
| - DAYS_TO_KEEP=7 | |||
| - BACKUP_CRON_EXPRESSION=0 0 * * * | |||
docker-compose.yml
Outdated
| @@ -17,6 +17,9 @@ services: | |||
| - TZ=UTC | |||
| - ADMIN_PASSWORD="adminPasswordHere" | |||
| - COMMUNITY=false # Enable this if you want your server to show up in the community servers tab, USE WITH SERVER_PASSWORD! | |||
| - BACKUP_ENABLED=false | |||
There was a problem hiding this comment.
Backups are enabled by default in the Dockerfile. Here you set it to false, what is the preferred status of this setting?
scripts/start.sh
Outdated
| @@ -67,6 +67,21 @@ if [ -n "${RCON_PORT}" ]; then | |||
| sed -i "s/RCONPort=[0-9]*/RCONPort=$RCON_PORT/" /palworld/Pal/Saved/Config/LinuxServer/PalWorldSettings.ini | |||
| fi | |||
|
|
|||
| if [[ -n "${BACKUP_ENABLED}" ]]; then | |||
There was a problem hiding this comment.
this needs to be if BACKUP_ENABLED = true, now it turns backups on even if the status is false
scripts/start.sh
Outdated
| echo "BACKUP_CRON_EXPRESSION=${BACKUP_CRON_EXPRESSION}" | ||
| fi | ||
|
|
||
| echo "${BACKUP_CRON_EXPRESSION} root bash /usr/local/bin/backup" > /etc/cron.d/backups-cron |
There was a problem hiding this comment.
this needs to be in the "else" clause, this will fail if BACKUP_CRON_EXPRESSION is empty
scripts/backup.sh
Outdated
| FILE_PATH="${DESTINATION_PATH}/backup_palworld_${DATE}.tar.gz" | ||
|
|
||
| if [ ! -f ${FILE_PATH} ]; then | ||
| echo "\e[0;32m***** CREATING BACKUPS FOLDER *****\e[0m\n" |
fryfrog
reviewed
Jan 25, 2024
scripts/start.sh
Outdated
| echo "BACKUP_CRON_EXPRESSION=${BACKUP_CRON_EXPRESSION}" | ||
| fi | ||
|
|
||
| echo "${BACKUP_CRON_EXPRESSION} root bash /usr/local/bin/backup" > /etc/cron.d/backups-cron |
There was a problem hiding this comment.
Can you do this as the steam user instead?
GuillaumeBarreau
force-pushed
the
main
branch
from
00468ac to
4ba38be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Setting Up Automatic Backups with Cron
Adding 3 new environment variables to automate the execution of backups on the server."
Environment Variables
DAYS_TO_KEEP:
Description: This environment variable represents the number of days to retain backup files. It is used in the cleanup process to remove backup files older than the specified duration. Example Usage: If set to 7, backup files older than 7 days will be deleted during the cleanup.
BACKUP_CRON_EXPRESSION:
Description: This environment variable defines the cron expression for scheduling automatic backups. It determines when the backup script should run at specific intervals. Example Usage: If set to 0 2 * * *, the backup script will run every day at 2:00 AM.
BACKUP_ENABLED:
Description: This environment variable indicates whether automatic backups are enabled or not. If set to a non-empty value, automatic backups will be enabled; otherwise, they will be disabled. Example Usage: If set to any non-empty string (e.g., true or 1), the backup script will be configured and executed as per the specified cron schedule.
Test instructions
You can try to set up these variables with this value if you want to save backups every minute.
BACKUP_ENABLED=true BACKUP_CRON_EXPRESSION=* * * * *Checklist before requesting a review