bug fix issue #72

thephpleague · Jan 7, 2019 · fdcab49 · fdcab49
1 parent 48a8fd0
commit fdcab49
Show file tree

Hide file tree

Showing 17 changed files with 24 additions and 23 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -16,7 +16,7 @@ matrix:
       env:
         - COLLECT_COVERAGE=true
         - IGNORE_PLATFORMS=false
-        - RUN_PHPSTAN=false
+        - RUN_PHPSTAN=true
         - RUN_INFECTION=false
         - VALIDATE_CODING_STYLE=false
     - php: 7.2
@@ -30,7 +30,7 @@ matrix:
       env:
         - COLLECT_COVERAGE=true
         - IGNORE_PLATFORMS=true
-        - RUN_PHPSTAN=false
+        - RUN_PHPSTAN=true
         - RUN_INFECTION=false
         - VALIDATE_CODING_STYLE=false
     - php: nightly

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,15 +2,15 @@
 
 All Notable changes to `Period` will be documented in this file
 
-## Next - TBD
+## 4.3.1 - 2019-01-07
 
 ### Added
 
 - None
 
 ### Fixed
 
-- None
+- `Datepoint::createFromFormat` see issue [#72](https://github.com/thephpleague/period/issues/72)
 
 ### Deprecated
 

diff --git a/composer.json b/composer.json
@@ -18,7 +18,7 @@
         "issues": "https://github.com/thephpleague/period/issues"
     },
     "require": {
-        "php" : ">=7.1.3"
+        "php" : "^7.1.3"
     },
     "require-dev": {
         "friendsofphp/php-cs-fixer": "^2.0",
@@ -50,9 +50,9 @@
         "phpunit": "phpunit --coverage-text",
         "infection": "infection -j$(nproc) --coverage=build --ignore-msi-with-no-mutations",
         "test": [
+            "@phpcs",
             "@phpstan-src",
             "@phpstan-tests",
-            "@phpcs",
             "@phpunit",
             "@infection"
         ]

diff --git a/src/Datepoint.php b/src/Datepoint.php
@@ -1,7 +1,7 @@
 <?php
 
 /**
- * League.Period (https://period.thephpleague.com).
+ * League.Period (https://period.thephpleague.com)
  *
  * (c) Ignace Nyamagana Butera <nyamsprod@gmail.com>
  *
@@ -59,12 +59,13 @@ public static function create($datepoint): self
     /**
      * @inheritdoc
      *
-     * @param string $format
-     * @param string $datetime
+     * @param string       $format
+     * @param string       $datetime
+     * @param DateTimeZone $timezone
      *
      * @return self|bool
      */
-    public static function createFromFormat($format, $datetime, DateTimeZone $timezone = null)
+    public static function createFromFormat($format, $datetime, $timezone = null)
     {
         $datepoint = parent::createFromFormat($format, $datetime, $timezone);
         if (false !== $datepoint) {

diff --git a/src/Duration.php b/src/Duration.php
@@ -1,7 +1,7 @@
 <?php
 
 /**
- * League.Period (https://period.thephpleague.com).
+ * League.Period (https://period.thephpleague.com)
  *
  * (c) Ignace Nyamagana Butera <nyamsprod@gmail.com>
  *

diff --git a/src/Exception.php b/src/Exception.php
@@ -1,7 +1,7 @@
 <?php
 
 /**
- * League.Period (https://period.thephpleague.com).
+ * League.Period (https://period.thephpleague.com)
  *
  * (c) Ignace Nyamagana Butera <nyamsprod@gmail.com>
  *

diff --git a/src/InvalidIndex.php b/src/InvalidIndex.php
@@ -1,7 +1,7 @@
 <?php
 
 /**
- * League.Period (https://period.thephpleague.com).
+ * League.Period (https://period.thephpleague.com)
  *
  * (c) Ignace Nyamagana Butera <nyamsprod@gmail.com>
  *

diff --git a/src/Period.php b/src/Period.php
@@ -1,7 +1,7 @@
 <?php
 
 /**
- * League.Period (https://period.thephpleague.com).
+ * League.Period (https://period.thephpleague.com)
  *
  * (c) Ignace Nyamagana Butera <nyamsprod@gmail.com>
  *

diff --git a/src/Sequence.php b/src/Sequence.php
@@ -1,7 +1,7 @@
 <?php
 
 /**
- * League.Period (https://period.thephpleague.com).
+ * League.Period (https://period.thephpleague.com)
  *
  * (c) Ignace Nyamagana Butera <nyamsprod@gmail.com>
  *

diff --git a/src/functions.php b/src/functions.php
@@ -1,7 +1,7 @@
 <?php
 
 /**
- * League.Period (https://period.thephpleague.com).
+ * League.Period (https://period.thephpleague.com)
  *
  * (c) Ignace Nyamagana Butera <nyamsprod@gmail.com>
  *

diff --git a/src/functions_include.php b/src/functions_include.php
@@ -1,7 +1,7 @@
 <?php
 
 /**
- * League.Period (https://period.thephpleague.com).
+ * League.Period (https://period.thephpleague.com)
  *
  * (c) Ignace Nyamagana Butera <nyamsprod@gmail.com>
  *

diff --git a/tests/DatepointTest.php b/tests/DatepointTest.php
@@ -1,7 +1,7 @@
 <?php
 
 /**
- * League.Period (https://period.thephpleague.com).
+ * League.Period (https://period.thephpleague.com)
  *
  * (c) Ignace Nyamagana Butera <nyamsprod@gmail.com>
  *

diff --git a/tests/DurationTest.php b/tests/DurationTest.php
@@ -1,7 +1,7 @@
 <?php
 
 /**
- * League.Period (https://period.thephpleague.com).
+ * League.Period (https://period.thephpleague.com)
  *
  * (c) Ignace Nyamagana Butera <nyamsprod@gmail.com>
  *

diff --git a/tests/ExtendedDate.php b/tests/ExtendedDate.php
@@ -1,7 +1,7 @@
 <?php
 
 /**
- * League.Period (https://period.thephpleague.com).
+ * League.Period (https://period.thephpleague.com)
  *
  * (c) Ignace Nyamagana Butera <nyamsprod@gmail.com>
  *

diff --git a/tests/FunctionTest.php b/tests/FunctionTest.php
@@ -1,7 +1,7 @@
 <?php
 
 /**
- * League.Period (https://period.thephpleague.com).
+ * League.Period (https://period.thephpleague.com)
  *
  * (c) Ignace Nyamagana Butera <nyamsprod@gmail.com>
  *

diff --git a/tests/PeriodTest.php b/tests/PeriodTest.php
@@ -1,7 +1,7 @@
 <?php
 
 /**
- * League.Period (https://period.thephpleague.com).
+ * League.Period (https://period.thephpleague.com)
  *
  * (c) Ignace Nyamagana Butera <nyamsprod@gmail.com>
  *

diff --git a/tests/SequenceTest.php b/tests/SequenceTest.php
@@ -1,7 +1,7 @@
 <?php
 
 /**
- * League.Period (https://period.thephpleague.com).
+ * League.Period (https://period.thephpleague.com)
  *
  * (c) Ignace Nyamagana Butera <nyamsprod@gmail.com>
  *