-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add sustainable web design model #58
feature: add sustainable web design model #58
Conversation
Thanks for this @drydenwilliams. I've added a few comments and requests for changes - mainly code comments and a typo TBH. If you make those changes I'm happy to merge these in, as it's a definite improvement on what we have right now 👍 |
Here's the issue for other bits that came up that I think are worth capturing, but not trying to address in this PR. this would make sense to use in a future version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Dryden, thanks for making this - there's a few small changes to make.
Thanks @mrchrisadams will take a look through this hopefully this week, thanks for taking the time again! |
Thanks for this Dryden! I'll merge it in now, and make a bit of time to update the README file as outlined in #60, and make any further tweaks needed to get it ready for publishing a new release. |
PR for issue #56
#56
### Acceptance criteria:
END_USER_DEVICE_ENERGY
annualSegmentEngergy
typo