Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add sustainable web design model #58

Conversation

drydenwilliams
Copy link
Contributor

@drydenwilliams drydenwilliams commented Dec 16, 2021

PR for issue #56

#56

### Acceptance criteria:

  • Link to where KWH_PER_GB figure comes from in code comment.
  • Fix all GLOABL_INTENSITY typos
  • Link to underlying source of carbon intensity info figure of 475, in being explicit about the year in use in code comment
  • replace 0.52 magic number with constant explaining what it represents i.e END_USER_DEVICE_ENERGY
  • fix annualSegmentEngergy typo
  • fix order of variables in energy per visit method, and reformat for more readability as described

@mrchrisadams
Copy link
Member

Thanks for this @drydenwilliams.

I've added a few comments and requests for changes - mainly code comments and a typo TBH. If you make those changes I'm happy to merge these in, as it's a definite improvement on what we have right now 👍

@mrchrisadams
Copy link
Member

mrchrisadams commented Feb 8, 2022

Here's the issue for other bits that came up that I think are worth capturing, but not trying to address in this PR. this would make sense to use in a future version.

#60

Copy link
Member

@mrchrisadams mrchrisadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Dryden, thanks for making this - there's a few small changes to make.

src/sustainable-web-design.js Show resolved Hide resolved
src/sustainable-web-design.js Outdated Show resolved Hide resolved
src/sustainable-web-design.js Outdated Show resolved Hide resolved
src/sustainable-web-design.js Outdated Show resolved Hide resolved
src/sustainable-web-design.js Outdated Show resolved Hide resolved
src/sustainable-web-design.js Outdated Show resolved Hide resolved
@drydenwilliams
Copy link
Contributor Author

Thanks @mrchrisadams will take a look through this hopefully this week, thanks for taking the time again!

@mrchrisadams
Copy link
Member

Thanks for this Dryden!

I'll merge it in now, and make a bit of time to update the README file as outlined in #60, and make any further tweaks needed to get it ready for publishing a new release.

@mrchrisadams mrchrisadams merged commit 101232c into thegreenwebfoundation:main Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants