Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spelling typo corrected #241

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

samuelIkoli
Copy link
Contributor

@samuelIkoli samuelIkoli commented Nov 14, 2024

Triage

Type of change

Please select any of the below items that are appropriate.

This pull request:

  • Adds a new carbon estimation model to CO2.js
  • Adds new functionality to an existing model
  • Fixes a bug with an existing model implementation
  • Add other new functionality to CO2.js
  • Add new data to CO2.js
  • Improves developer experience for contributors
  • Adds contributors to CO2.js
  • Does something not specified above

Related issue/s

Please list below any issues this pull request is related to.

Docs changes required

Do any changes made in this pull request require parts of the CO2.js documentation to be updated?

  • Yes
  • No
  • I don't know

If you answered "Yes", please create an corresponding issue in our Developer Documentation repository.

Describe the changes made in this pull request

Just a possible spelling correction

@mrchrisadams
Copy link
Member

mrchrisadams commented Nov 15, 2024

Hi @samuelIkoli - thanks for your PR!

I've just updated the testing matrix to use more up-to-date versions of NodeJS in the Github Actions CI runs.

Would you mind rebasing this PR from main to include the latest updates? I think this ought to fix the failing tests, so we can merge this in.

@samuelIkoli
Copy link
Contributor Author

samuelIkoli commented Nov 15, 2024

@mrchrisadams done. You can review again.

Also, when I tried using CO2.JS as an nom package in my react (javascript) site, when doing the check to see if your domain hosting is green, rather than the 'hosting.check(domain)' which is on the official documentation (kept giving a 'hosting.check is not a function), what worked was hosting(domain).

@mrchrisadams mrchrisadams merged commit 431492d into thegreenwebfoundation:main Nov 15, 2024
3 checks passed
@mrchrisadams
Copy link
Member

mrchrisadams commented Nov 15, 2024

Thanks @samuelIkoli!

I'll raise an issue about the the docs so we can investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants