Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to return proper results when variables with 0 value are passed into function #179

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

fershad
Copy link
Contributor

@fershad fershad commented Nov 7, 2023

Fix for #173

Fixes the situations below:

  • Currently, when grid intensity for any system segment is set to 0 the calculation will default to the Global Average Grid Intensity. This is not right, as the user has passed in a value for a reason and this should be respected in the calculations.
  • Currently, when the data reload percentage is set to 0 the default value of 0.02 is used instead.
  • Currently, when the first or returning visitor percentage is set to 0 the default values (0.75 and 0.25) are used instead.

@fershad fershad merged commit b1c0679 into main Nov 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant