GH-525 cache constants and GH-526 query optimizer #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmottestad
commented
Nov 27, 2024
qendpoint-store/src/main/java/com/the_qa_company/qendpoint/utils/VariableToIdSubstitution.java
Outdated
Show resolved
Hide resolved
hmottestad
force-pushed
the
GH-525-cache-constants-and-GH-526-query-optimizer
branch
from
f57744a to
ed4fb40
Compare
…r and move from node-sass to sass
…he StatementPattern level
hmottestad
force-pushed
the
GH-525-cache-constants-and-GH-526-query-optimizer
branch
from
ed4fb40 to
7792de4
Compare
|
@ate47 I've added some tests and also cleaned up the commits. Should be ready for a final review or merge. |
hmottestad
commented
Nov 28, 2024
Comment on lines
-58
to
-59
| "node-sass": "^7.0.1", | ||
| "sparql-formatter": "^0.7.6" |
There was a problem hiding this comment.
https://www.npmjs.com/package/node-sass
This package has been deprecated
Author message:Node Sass is no longer supported. Please use
sassorsass-embeddedinstead.
There was a problem hiding this comment.
I had to update in order to build the frontend.
hmottestad
deleted the
GH-525-cache-constants-and-GH-526-query-optimizer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue resolved (if any): #525 and #526
Description of this pull request:
Please check all the lines before posting the pull request:
mvn formatter:formaton the backend,npm run formaton the frontend) before posting my pull request,mvn formatter:validateto validate the formatting on the backend,npm run validateon the frontend