Fix matcher cache #8039
Merged
Fix matcher cache #8039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: alanprot <alanprot@gmail.com>
3 tasks
pedro-stanaka
approved these changes
Jan 3, 2025
yeya24
reviewed
Jan 3, 2025
pkg/store/cache/matchers_cache.go
Outdated
| @@ -89,9 +89,9 @@ func NewMatchersCache(opts ...MatcherCacheOption) (*LruMatchersCache, error) { | |||
|
|
|||
| func (c *LruMatchersCache) GetOrSet(key ConversionLabelMatcher, newItem NewItemFunc) (*labels.Matcher, error) { | |||
There was a problem hiding this comment.
Do we still want ConversionLabelMatcher in the method itself?
There was a problem hiding this comment.
I was thinking the same... maybe better to send the key as string... lemme do that
There was a problem hiding this comment.
Actually, we need as the key is also used as argument of the NewItemFunc. =/ We can change this function to not receive the key as well i think.. but is a bigger change.
There was a problem hiding this comment.
@yeya24 PTAL? tried to simplify the code a bit.
alanprot
force-pushed
the
fix-cache-matcher
branch
from
5653cd5 to
a5634c8
Compare
Signed-off-by: alanprot <alanprot@gmail.com>
alanprot
force-pushed
the
fix-cache-matcher
branch
from
a5634c8 to
6083b3d
Compare
pedro-stanaka
approved these changes
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #7353
On the previous PR, we were using the reference of the matcher as a cache key -> This does not work as for every request, we create new references for those matchers.
This PR is just changing the cache key to be a string.
Changes
Change matchers cache key to be an string
Verification
Test was updated.