Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add block lifecycle callback #8036

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Jan 3, 2025

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Fixes #8029

This PR adds a new interface called BlockLifecycleCallback which only has 1 method PreAdd now. PreAdd can be used to customize the logic to see if a block needs to be added by the current store gateway instance

Verification

@yeya24 yeya24 marked this pull request as ready for review January 5, 2025 19:06
@yeya24 yeya24 force-pushed the block-lifecycle-hook branch from 88848f4 to 613d0da Compare January 6, 2025 04:58
Signed-off-by: Ben Ye <benye@amazon.com>
@yeya24 yeya24 force-pushed the block-lifecycle-hook branch from 613d0da to 9ca985e Compare January 6, 2025 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store Gateway: Expose hook before adding blocks when sync
1 participant