-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: optimize state transitions #4473
Conversation
✅ Deploy Preview for teslamate ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Tests pass on my box :-) Hope I have read @micves comments on this correctly. #4453 (comment) |
5e4900f
to
acfb3c0
Compare
This was split on from #4453 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
I love how you fillet big changes into small happens
@micves May I ask you to review as well? |
Nice work, its spot on :)
Yes, lgtm and approved 👍 |
Have been looking at Jujutsu, which makes this sort a log easier then plan git. There is a lot of youtube videos, blogs, etc on jujutsu, mostly positive opinions. Home page is https://jj-vcs.github.io/jj/latest/ There is a learning curve though. It does some fundamental things very differently to git, which is very likely to catch you by surprise if you are use to git (apparently these come from Mercurial). |
Note there are three distinct changes, each one is a separate commit.