feat: add confidential nodes example #2227
Conversation
arthurlapertosa
requested review from
apeabody,
ericyz and
a team
as code owners
|
cc @erlanderlo |
There was a problem hiding this comment.
Thanks for the contribution @arthurlapertosa!
A few initial notes to get the tests ready.
| "github.com/terraform-google-modules/terraform-google-kubernetes-engine/test/integration/testutils" | ||
| ) | ||
|
|
||
| func TestConfidentialSaferCluster(t *testing.T) { |
There was a problem hiding this comment.
Please add new apply, validate, teardown for TestConfidentialSaferCluster in https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/build/int.cloudbuild.yaml#L37
You don't need to worry about init as that is automatically done for all examples.
| "nodePools.management.autoRepair", | ||
| "nodePools.shieldedInstanceConfig", | ||
| } | ||
| for _, pth := range validateJSONPaths { |
There was a problem hiding this comment.
You could consider using the new testutils.TGKEAssertGolden(), example: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/test/integration/node_pool/node_pool_test.go#L63
Just include all the paths/values you want to test in TestConfidentialSaferCluster.json
|
|
||
| bpt.DefineVerify(func(assert *assert.Assertions) { | ||
| // Skipping Default Verify as the Verify Stage fails due to change in Client Cert Token | ||
| // bpt.DefaultVerify(assert) |
There was a problem hiding this comment.
Please include testutils.TGKEVerify() as it only verifies the resources, not the outputs
| // bpt.DefaultVerify(assert) | |
| // bpt.DefaultVerify(assert) | |
| testutils.TGKEVerify(t, bpt, assert) // Verify Resources |
| */ | ||
|
|
||
| terraform { | ||
| required_version = ">= 0.13" |
There was a problem hiding this comment.
nit: we are moving to min TF v1.3
| required_version = ">= 0.13" | |
| required_version = ">= 1.3" |
No description provided.