fix: node_pools_cgroup_mode var does not correctly handle the "all" map key #2224

DrFaust92 · 2024-12-21T21:15:15Z

apeabody · 2024-12-23T17:41:49Z

/gcbrun

apeabody · 2024-12-23T18:27:30Z

TestNodePool 2024-12-23T18:03:29Z retry.go:99: Returning due to fatal error: FatalError{Underlying: error while running command: exit status 1; 
Error: Error in function call

  on ../../../modules/beta-public-cluster/cluster.tf line 876, in resource "google_container_node_pool" "pools":
 876:         cgroup_mode = coalesce(local.node_pools_cgroup_mode[each.value["name"]], local.node_pools_cgroup_mode["all"]) == "" ? null : coalesce(local.node_pools_cgroup_mode[each.value["name"]], local.node_pools_cgroup_mode["all"])
    ├────────────────
    │ each.value["name"] is "pool-01"
    │ local.node_pools_cgroup_mode is object with 7 attributes
    │ local.node_pools_cgroup_mode["all"] is ""

Call to function "coalesce" failed: no non-null, non-empty-string arguments.

Error: Error in function call

  on ../../../modules/beta-public-cluster/cluster.tf line 876, in resource "google_container_node_pool" "pools":
 876:         cgroup_mode = coalesce(local.node_pools_cgroup_mode[each.value["name"]], local.node_pools_cgroup_mode["all"]) == "" ? null : coalesce(local.node_pools_cgroup_mode[each.value["name"]], local.node_pools_cgroup_mode["all"])
    ├────────────────
    │ each.value["name"] is "pool-05"
    │ local.node_pools_cgroup_mode is object with 7 attributes
    │ local.node_pools_cgroup_mode["all"] is ""

Call to function "coalesce" failed: no non-null, non-empty-string arguments.

Error: Error in function call

  on ../../../modules/beta-public-cluster/cluster.tf line 876, in resource "google_container_node_pool" "pools":
 876:         cgroup_mode = coalesce(local.node_pools_cgroup_mode[each.value["name"]], local.node_pools_cgroup_mode["all"]) == "" ? null : coalesce(local.node_pools_cgroup_mode[each.value["name"]], local.node_pools_cgroup_mode["all"])
    ├────────────────
    │ each.value["name"] is "pool-03"
    │ local.node_pools_cgroup_mode is object with 7 attributes
    │ local.node_pools_cgroup_mode["all"] is ""

Call to function "coalesce" failed: no non-null, non-empty-string arguments.

Error: Error in function call

  on ../../../modules/beta-public-cluster/cluster.tf line 876, in resource "google_container_node_pool" "pools":
 876:         cgroup_mode = coalesce(local.node_pools_cgroup_mode[each.value["name"]], local.node_pools_cgroup_mode["all"]) == "" ? null : coalesce(local.node_pools_cgroup_mode[each.value["name"]], local.node_pools_cgroup_mode["all"])
    ├────────────────
    │ each.value["name"] is "pool-02"
    │ local.node_pools_cgroup_mode is object with 7 attributes
    │ local.node_pools_cgroup_mode["all"] is ""

Call to function "coalesce" failed: no non-null, non-empty-string arguments.

Error: Error in function call

  on ../../../modules/beta-public-cluster/cluster.tf line 876, in resource "google_container_node_pool" "pools":
 876:         cgroup_mode = coalesce(local.node_pools_cgroup_mode[each.value["name"]], local.node_pools_cgroup_mode["all"]) == "" ? null : coalesce(local.node_pools_cgroup_mode[each.value["name"]], local.node_pools_cgroup_mode["all"])
    ├────────────────
    │ each.value["name"] is "pool-04"
    │ local.node_pools_cgroup_mode is object with 7 attributes
    │ local.node_pools_cgroup_mode["all"] is ""

Call to function "coalesce" failed: no non-null, non-empty-string arguments.}
    apply.go:34: 
        	Error Trace:	/builder/home/go/pkg/mod/github.com/gruntwork-io/terratest@v0.48.1/modules/terraform/apply.go:34
        	            				/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/blueprint-test@v0.17.3/pkg/tft/terraform.go:571
        	            				/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/blueprint-test@v0.17.3/pkg/tft/terraform.go:630
        	            				/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/blueprint-test@v0.17.3/pkg/tft/terraform.go:669
        	            				/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/blueprint-test@v0.17.3/pkg/utils/stages.go:31
        	            				/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/blueprint-test@v0.17.3/pkg/tft/terraform.go:669
        	Error:      	Received unexpected error:
        	            	FatalError{Underlying: error while running command: exit status 1; 
        	            	Error: Error in function call
        	            	
        	            	  on ../../../modules/beta-public-cluster/cluster.tf line 876, in resource "google_container_node_pool" "pools":
        	            	 876:         cgroup_mode = coalesce(local.node_pools_cgroup_mode[each.value["name"]], local.node_pools_cgroup_mode["all"]) == "" ? null : coalesce(local.node_pools_cgroup_mode[each.value["name"]], local.node_pools_cgroup_mode["all"])
        	            	    ├────────────────
        	            	    │ each.value["name"] is "pool-01"
        	            	    │ local.node_pools_cgroup_mode is object with 7 attributes
        	            	    │ local.node_pools_cgroup_mode["all"] is ""
        	            	
        	            	Call to function "coalesce" failed: no non-null, non-empty-string arguments.
        	            	
        	            	Error: Error in function call
        	            	
        	            	  on ../../../modules/beta-public-cluster/cluster.tf line 876, in resource "google_container_node_pool" "pools":
        	            	 876:         cgroup_mode = coalesce(local.node_pools_cgroup_mode[each.value["name"]], local.node_pools_cgroup_mode["all"]) == "" ? null : coalesce(local.node_pools_cgroup_mode[each.value["name"]], local.node_pools_cgroup_mode["all"])
        	            	    ├────────────────
        	            	    │ each.value["name"] is "pool-05"
        	            	    │ local.node_pools_cgroup_mode is object with 7 attributes
        	            	    │ local.node_pools_cgroup_mode["all"] is ""
        	            	
        	            	Call to function "coalesce" failed: no non-null, non-empty-string arguments.
        	            	
        	            	Error: Error in function call
        	            	
        	            	  on ../../../modules/beta-public-cluster/cluster.tf line 876, in resource "google_container_node_pool" "pools":
        	            	 876:         cgroup_mode = coalesce(local.node_pools_cgroup_mode[each.value["name"]], local.node_pools_cgroup_mode["all"]) == "" ? null : coalesce(local.node_pools_cgroup_mode[each.value["name"]], local.node_pools_cgroup_mode["all"])
        	            	    ├────────────────
        	            	    │ each.value["name"] is "pool-03"
        	            	    │ local.node_pools_cgroup_mode is object with 7 attributes
        	            	    │ local.node_pools_cgroup_mode["all"] is ""
        	            	
        	            	Call to function "coalesce" failed: no non-null, non-empty-string arguments.
        	            	
        	            	Error: Error in function call
        	            	
        	            	  on ../../../modules/beta-public-cluster/cluster.tf line 876, in resource "google_container_node_pool" "pools":
        	            	 876:         cgroup_mode = coalesce(local.node_pools_cgroup_mode[each.value["name"]], local.node_pools_cgroup_mode["all"]) == "" ? null : coalesce(local.node_pools_cgroup_mode[each.value["name"]], local.node_pools_cgroup_mode["all"])
        	            	    ├────────────────
        	            	    │ each.value["name"] is "pool-02"
        	            	    │ local.node_pools_cgroup_mode is object with 7 attributes
        	            	    │ local.node_pools_cgroup_mode["all"] is ""
        	            	
        	            	Call to function "coalesce" failed: no non-null, non-empty-string arguments.
        	            	
        	            	Error: Error in function call
        	            	
        	            	  on ../../../modules/beta-public-cluster/cluster.tf line 876, in resource "google_container_node_pool" "pools":
        	            	 876:         cgroup_mode = coalesce(local.node_pools_cgroup_mode[each.value["name"]], local.node_pools_cgroup_mode["all"]) == "" ? null : coalesce(local.node_pools_cgroup_mode[each.value["name"]], local.node_pools_cgroup_mode["all"])
        	            	    ├────────────────
        	            	    │ each.value["name"] is "pool-04"
        	            	    │ local.node_pools_cgroup_mode is object with 7 attributes
        	            	    │ local.node_pools_cgroup_mode["all"] is ""
        	            	
        	            	Call to function "coalesce" failed: no non-null, non-empty-string arguments.}
        	Test:       	TestNodePool

apeabody

Thanks for the contribution @DrFaust92!

I'd like to include this in v35.0.1 #2219

DrFaust92 · 2024-12-26T19:04:40Z

checking!

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>

DrFaust92 · 2024-12-26T22:10:25Z

apeabody did local best effort to test, plan works fine in all scenarios + added it to tests

apeabody · 2024-12-26T22:16:26Z

/gcbrun

examples/node_pool/main.tf

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>

apeabody · 2024-12-28T15:56:40Z

/gcbrun

apeabody · 2024-12-29T00:43:47Z

@DrFaust92 - Thanks, looks like the test works, but node pool 1 as-built is EFFECTIVE_CGROUP_MODE_V1?

Step #59 - "verify node-pool-local": TestNodePool 2024-12-28T16:28:24Z command.go:100: Running command gcloud with args [config get-value project --format json]
Step #59 - "verify node-pool-local":     utils.go:110: 
Step #59 - "verify node-pool-local":         	Error Trace:	/workspace/test/integration/testutils/utils.go:110
Step #59 - "verify node-pool-local":         	            				/builder/home/go/pkg/mod/golang.org/x/sync@v0.10.0/errgroup/errgroup.go:78
Step #59 - "verify node-pool-local":         	            				/usr/lib/go/src/runtime/asm_amd64.s:1700
Step #59 - "verify node-pool-local":         	Error:      	Not equal: 
Step #59 - "verify node-pool-local":         	            	expected: "EFFECTIVE_CGROUP_MODE_V2"
Step #59 - "verify node-pool-local":         	            	actual  : "EFFECTIVE_CGROUP_MODE_V1"
Step #59 - "verify node-pool-local":         	            	
Step #59 - "verify node-pool-local":         	            	Diff:
Step #59 - "verify node-pool-local":         	            	--- Expected
Step #59 - "verify node-pool-local":         	            	+++ Actual
Step #59 - "verify node-pool-local":         	            	@@ -1 +1 @@
Step #59 - "verify node-pool-local":         	            	-EFFECTIVE_CGROUP_MODE_V2
Step #59 - "verify node-pool-local":         	            	+EFFECTIVE_CGROUP_MODE_V1
Step #59 - "verify node-pool-local":         	Test:       	TestNodePool
Step #59 - "verify node-pool-local":         	Messages:   	For node pool-01 path "config.effectiveCgroupMode" expected "EFFECTIVE_CGROUP_MODE_V1" to match fixture "EFFECTIVE_CGROUP_MODE_V2"

I'm seeing this in the plan (looks like pool-01 IS being created with "CGROUP_MODE_V1"):

Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:   # module.example.module.gke.google_container_node_pool.pools["pool-01"] will be created
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:   + resource "google_container_node_pool" "pools" {
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:       + cluster                     = (known after apply)
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:       + id                          = (known after apply)
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:       + initial_node_count          = 1
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:       + instance_group_urls         = (known after apply)
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:       + location                    = "europe-west4"
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:       + managed_instance_group_urls = (known after apply)
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:       + max_pods_per_node           = (known after apply)
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:       + name                        = "pool-01"
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:       + name_prefix                 = (known after apply)
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:       + node_count                  = (known after apply)
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:       + node_locations              = (known after apply)
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:       + operation                   = (known after apply)
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:       + project                     = "ci-gke-45fd3c29-ws55"
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:       + version                     = (known after apply)
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185: 
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:       + autoscaling {
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:           + location_policy = (known after apply)
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:           + max_node_count  = 2
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:           + min_node_count  = 1
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:         }
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185: 
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:       + management {
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:           + auto_repair  = true
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:           + auto_upgrade = true
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:         }
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185: 
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:       + network_config (known after apply)
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185: 
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:       + node_config {
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:           + disk_size_gb                = 100
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:           + disk_type                   = "pd-standard"
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:           + effective_taints            = (known after apply)
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:           + enable_confidential_storage = false
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:           + image_type                  = "COS_CONTAINERD"
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:           + labels                      = (known after apply)
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:           + local_ssd_count             = 0
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:           + logging_variant             = "DEFAULT"
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:           + machine_type                = "e2-medium"
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:           + metadata                    = (known after apply)
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:           + min_cpu_platform            = (known after apply)
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:           + oauth_scopes                = [
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:               + "https://www.googleapis.com/auth/cloud-platform",
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:             ]
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:           + preemptible                 = false
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:           + service_account             = "gke-sa-int-test-p1-7ee9@ci-gke-45fd3c29-ws55.iam.gserviceaccount.com"
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:           + spot                        = false
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:           + tags                        = (known after apply)
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:             # (1 unchanged attribute hidden)
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185: 
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:           + confidential_nodes (known after apply)
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185: 
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:           + gcfs_config {
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:               + enabled = false
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:             }
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185: 
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:           + guest_accelerator (known after apply)
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185: 
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:           + kubelet_config (known after apply)
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185: 
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:           + linux_node_config {
Step #58 - "apply node-pool-local": TestNodePool 2024-12-28T16:17:51Z command.go:185:               + cgroup_mode = "CGROUP_MODE_V1"

Also for the cluster:

Step #59 - "verify node-pool-local": TestNodePool 2024-12-28T16:28:17Z command.go:100: Running command gcloud with args [config get-value project --format json]
Step #59 - "verify node-pool-local":     golden.go:160: 
Step #59 - "verify node-pool-local":         	Error Trace:	/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/blueprint-test@v0.17.3/pkg/golden/golden.go:160
Step #59 - "verify node-pool-local":         	            				/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/blueprint-test@v0.17.3/pkg/golden/golden.go:171
Step #59 - "verify node-pool-local":         	            				/builder/home/go/pkg/mod/golang.org/x/sync@v0.10.0/errgroup/errgroup.go:78
Step #59 - "verify node-pool-local":         	            				/usr/lib/go/src/runtime/asm_amd64.s:1700
Step #59 - "verify node-pool-local":         	Error:      	Not equal: 
Step #59 - "verify node-pool-local":         	            	expected: "EFFECTIVE_CGROUP_MODE_V1"
Step #59 - "verify node-pool-local":         	            	actual  : "EFFECTIVE_CGROUP_MODE_V2"
Step #59 - "verify node-pool-local":         	            	
Step #59 - "verify node-pool-local":         	            	Diff:
Step #59 - "verify node-pool-local":         	            	--- Expected
Step #59 - "verify node-pool-local":         	            	+++ Actual
Step #59 - "verify node-pool-local":         	            	@@ -1 +1 @@
Step #59 - "verify node-pool-local":         	            	-EFFECTIVE_CGROUP_MODE_V1
Step #59 - "verify node-pool-local":         	            	+EFFECTIVE_CGROUP_MODE_V2
Step #59 - "verify node-pool-local":         	Test:       	TestNodePool
Step #59 - "verify node-pool-local":         	Messages:   	For path "nodeConfig.effectiveCgroupMode" expected "EFFECTIVE_CGROUP_MODE_V2" to match fixture "EFFECTIVE_CGROUP_MODE_V1"

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>

DrFaust92 · 2024-12-29T01:39:27Z

checking

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>

DrFaust92 · 2024-12-29T17:51:12Z

apeabody I think its good now, I swapped the order of checking "all" and specific node config. first it should check node pool specific and then default to all (or nothing if not specified)

Local plan looks good now

apeabody · 2024-12-30T17:03:48Z

/gcbrun

cluster.tf

Co-authored-by: Andrew Peabody <andrewpeabody@google.com>

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>

apeabody · 2025-01-02T19:00:08Z

/gcbrun

apeabody

Thanks @DrFaust92! LGTM

…ap key (terraform-google-modules#2224) Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> Co-authored-by: Andrew Peabody <andrewpeabody@google.com>

DrFaust92 requested review from ericyz and a team as code owners December 21, 2024 21:15

apeabody self-assigned this Dec 23, 2024

apeabody requested changes Dec 26, 2024

View reviewed changes

DrFaust92 added 2 commits December 26, 2024 14:05

fix cgroup all

882db61

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>

attmept cgroup fix

f0e941c

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>

DrFaust92 force-pushed the cgroup-all branch from ea7b85b to f0e941c Compare December 26, 2024 19:21

DrFaust92 marked this pull request as draft December 26, 2024 19:21

DrFaust92 added 2 commits December 26, 2024 15:28

attmept cgroup fix

ce811af

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>

attmept cgroup fix

a1b7da1

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>

DrFaust92 marked this pull request as ready for review December 26, 2024 22:09

DrFaust92 requested a review from apeabody December 26, 2024 22:10

apeabody reviewed Dec 27, 2024

View reviewed changes

examples/node_pool/main.tf Show resolved Hide resolved

CR comments

bcb2a6c

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>

DrFaust92 requested a review from apeabody December 28, 2024 14:34

Merge branch 'master' into cgroup-all

c08b92d

CR comments

4b6745f

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>

DrFaust92 added 3 commits December 29, 2024 12:36

CR comments

b3ce28b

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>

CR comments

8a99082

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>

CR comments

70d9890

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>

apeabody reviewed Dec 30, 2024

View reviewed changes

cluster.tf Outdated Show resolved Hide resolved

apeabody mentioned this pull request Dec 30, 2024

chore(master): release 35.0.1 #2219

Merged

DrFaust92 and others added 2 commits January 1, 2025 19:22

Update cluster.tf

5574df3

Co-authored-by: Andrew Peabody <andrewpeabody@google.com>

CR comments

7f0f2c2

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>

DrFaust92 requested a review from apeabody January 2, 2025 00:44

apeabody approved these changes Jan 2, 2025

View reviewed changes

apeabody merged commit 53b1a50 into terraform-google-modules:master Jan 2, 2025
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: node_pools_cgroup_mode var does not correctly handle the "all" map key #2224

fix: node_pools_cgroup_mode var does not correctly handle the "all" map key #2224

DrFaust92 commented Dec 21, 2024

apeabody commented Dec 23, 2024

apeabody commented Dec 23, 2024

apeabody left a comment •

edited

Loading

DrFaust92 commented Dec 26, 2024

DrFaust92 commented Dec 26, 2024

apeabody commented Dec 26, 2024

apeabody commented Dec 28, 2024

apeabody commented Dec 29, 2024

DrFaust92 commented Dec 29, 2024

DrFaust92 commented Dec 29, 2024

apeabody commented Dec 30, 2024

apeabody commented Jan 2, 2025

apeabody left a comment

fix: node_pools_cgroup_mode var does not correctly handle the "all" map key #2224

fix: node_pools_cgroup_mode var does not correctly handle the "all" map key #2224

Conversation

DrFaust92 commented Dec 21, 2024

apeabody commented Dec 23, 2024

apeabody commented Dec 23, 2024

apeabody left a comment • edited Loading

Choose a reason for hiding this comment

DrFaust92 commented Dec 26, 2024

DrFaust92 commented Dec 26, 2024

apeabody commented Dec 26, 2024

apeabody commented Dec 28, 2024

apeabody commented Dec 29, 2024

DrFaust92 commented Dec 29, 2024

DrFaust92 commented Dec 29, 2024

apeabody commented Dec 30, 2024

apeabody commented Jan 2, 2025

apeabody left a comment

Choose a reason for hiding this comment

apeabody left a comment •

edited

Loading