Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dart] Migrate Kendo icons to dart-sass module system #388

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

epetrow
Copy link
Contributor

@epetrow epetrow commented Nov 4, 2024

No description provided.

@epetrow epetrow self-assigned this Nov 4, 2024
@epetrow epetrow requested a review from a team as a code owner November 4, 2024 12:09
@inikolova inikolova self-requested a review November 5, 2024 08:11
@zhpenkov zhpenkov self-requested a review November 5, 2024 08:45
@epetrow epetrow requested a review from Juveniel November 5, 2024 09:33
BREAKING CHANGE

Starting with the R4 2024 release the Kendo Font and SVG icons are now
migrated to the SASS module system. This breaking change is due to the
`node-sass` package reaching its official end of life.

For more information, please refer to the following links:

* https://sass-lang.com/blog/the-module-system-is-launched/
* sass/node-sass@107ded9
Copy link
Contributor

@zhpenkov zhpenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Configuration works, dist.css is the same.

@Juveniel Juveniel merged commit 813851b into develop Nov 6, 2024
1 check passed
@Juveniel Juveniel deleted the migrate-icons branch November 6, 2024 11:34
@Juveniel Juveniel changed the title Migrate Kendo icons to dart-sass module system [Dart] Migrate Kendo icons to dart-sass module system Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants