Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable cors, read ACCESS_CONTROL_ALLOW_ORIGIN from env #236

Merged
merged 7 commits into from
Oct 30, 2023
Merged

feat: enable cors, read ACCESS_CONTROL_ALLOW_ORIGIN from env #236

merged 7 commits into from
Oct 30, 2023

Conversation

Jaszkowic
Copy link
Collaborator

@Jaszkowic Jaszkowic commented Oct 23, 2023 •
edited
Loading

New env needed in Vercel:

ACCESS_CONTROL_ALLOW_ORIGIN set to https://giessdenkiez.de

@Jaszkowic Jaszkowic requested a review from ff6347 as a code owner October 23, 2023 15:02
@Jaszkowic Jaszkowic temporarily deployed to ci_test October 24, 2023 12:20 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Oct 24, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
giessdenkiez-de-postgres-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2023 3:11pm

@Jaszkowic Jaszkowic temporarily deployed to ci_test October 26, 2023 13:17 — with GitHub Actions Inactive
@ff6347
Copy link
Collaborator

ff6347 commented Oct 26, 2023

Does this have to be a secret in the tests?

ff6347
ff6347 approved these changes Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@ff6347 ff6347 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ship it!

@Jaszkowic Jaszkowic merged commit 7034496 into staging Oct 30, 2023
2 checks passed
@Jaszkowic Jaszkowic deleted the feat/cors branch October 30, 2023 08:26
@ff6347 ff6347 mentioned this pull request Oct 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ff6347 ff6347 ff6347 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jaszkowic @ff6347