Make input geometry configurable #85
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shapely.cascaded_union is deprecated, but as this change may have unforseen effects, it should really be done in a separate PR.
|
Very nice thank you. I'll give it a spin next week. I'd love to have a workflow that runs this script as well. Would be a great addition to this PR. (Wink wink nudge nudge) if your not able to work on this I will delay the approval until we have a working action |
|
Delayed until workflow exists #86 |
|
thanks @sjockers , in the meantime we have refactored the harvester quite a lot, but your proposal is still useful! in case you can find the time feel free to merge staging and resolve the conflicts 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it easier to use this project for regions other than Berlin by adding .env parameters for configuring the source shapefile for the buffer:
Defaults to previous settings (Berlin shapefile, buffer distance of 2000).
[This is a local duplicate of #82 in order to properly run checks, with access to secrets]