Add parallelism to speed up filter_by_quadkey #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option for users to use parallelism via the built-in
parallel::mcmapply
function as a drop-in replacement formapply
infilter_by_quadkey
. This significantly speeds up runningfilter_by_quadkey
:The function
filter_by_quadkey
takes the sametiles
andbbox
args and adds two more:parallel = FALSE
andncores = NULL)
. Parallelism is turned off by default because R's built inparallel
often causes issues on Windows machines. A check of the operating system is triggered and returns a warning on Windows machines.The original function is revised with a conditional flow depending on whether parallelism is enabled. When set to
TRUE
, the original logic is replaced like this:If parallelism is selected, the number of active threads is set to max available minus one using
parallel::detectCores()
. This can be overriden using thencores
argument in the function.