forked from element-hq/element-x-ios
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase/element x ios 1.9.4 #22
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update various packages. Notable changes: - DeviceKit now detects iPad Pro (M4), iPad Air (M2) and iPhones 16. - KZFileWatchers isn't updated but now has a tag to pin to. * Try using a raw destination for tests. To fix an issue where CI isn't finding iPhone 16 when it's clearly listed by simctl.
We don't use any of the TabView features and it shows a tab bar at the bottom when the list is long.
element-hq#3326) * Upgrade Kingfisher to fix a bug the prevented GIFs from being tapped. onevcat/Kingfisher#2295 * Fix tests.
… the start screen. (element-hq#3316) * Don't query the homeserver until confirming it (or selecting a different one). * Setup the infrastructure to test AuthenticationService. Implement basic tests for configuration & password login. * Use the real AuthenticationService with a mock Client in all of the tests. * Add tests for the ServerConfirmationScreenViewModel. * Remove redundant view state and test for it.
* Send a message from integration tests and check that it doesn't show up in the app logs * Increase photo library timeout * Wait for image tapping to process * Send a message using the rich text editor too * Wait for the various pickers to finish loading * Set all logs to `trace` in integration tests * Close formatting options after sending the second message * Make sure logs are actually sent to tracing and get redirected to the right file * Switch from using a custom `trace` log configuration to the lowest level `TracingConfiguration` we support
* Wait longer on authentication flow tests. * Move default perceptualPrecision value into the snapshot preferences. * Delay snapshots *before* setting up the test. * Reset the simulators on GitHub before running? * Remove a test that is now handled by Rust. * Fix a test that was yielding.
… the back button). (element-hq#3335) * Make sure the room header takes up as much space as possible (to hide the back button). * Ignore coverage on the developer options screen.
…on from ending the call - previously handled in 7818fa6 - seems the default behavior changed and we now need to manually configure the AudioSession
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Disable image and document picker integration tests as they randomly fail to load and are flakey. * Delete any pre-existing log files * Various tracing tweaks and fixes: - delete the custom tracing log levels as we can't control their ouput - implement comparable on them - change default levels only if the new chosen level increases their verbosity * Make logging targets mandatory and fix their logging levels * Switch back to using the `run_tests` reset simulator flag as `fastlane snapshot reset_simulators` was too generic and slow * Switch all integration test taps to `tapCenter` (nee forceTap) after noticing missed taps on CI. * Make the logging file prefix explicit, let the main app not use one. * Rename tracing configuration `target` to `currentTarget`
…tting you continue to a failure later. (element-hq#3342) * Fail configuration of the authentication service if the homeserver doesn't support login. * Move the ServerSelectionCoordinator logic into the ViewModel. - Handle the new login alert. - Add more tests
Fix analytics service optionality.
* Refactor RoundedLabelItem into the Compound VisualListItem component. * Update the design of SecureBackupKeyBackupScreen. * Add a hint to the key storage toggle when disabled.
* Update the banner strings for out of sync key storage. * Update string on SecureBackupScreen. * Update snapshots * Update an alert string we weren't using on iOS, and use it at the same place as Android.
* Enable the Optimised Media Uploads feature. (Well move the toggle from Developer Options to Advanced Settings) * Add OptimizeMediaUploads analytics. * Final strings. * Upload reduced quality media by default 😢 Move the setting out of the feature flags section in the file. * Fix unit tests now the default has changed. * Pull in updated string, fix snapshots.
* Manage the secure backup screens with flow coordinators. * Add UI tests for the EncryptionSettingsFlowCoordinator. * Realise that the settings flow can't reset anymore and remove the sub-flow 🤦♂️ * Add UI tests for the EncryptionResetFlowCoordinator.
…calls. (element-hq#3487) * Fix a race condition observing room info updates for calls. * Fix a bug where call observation wasn't set up if the call comes when the app has been killed.
…pdates for longer.
…which the app was suspended but not terminated.
* update SDK * use send queue should be false
Generated by 🚫 Danger Swift against bfa7ffb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #21