-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ootle): init Tari Ootle #1377
Draft
karczuRF
wants to merge
60
commits into
tari-project:feat/tapplets
Choose a base branch
from
karczuRF:feat/tari-ootle
base: feat/tapplets
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description --- Resolves tari-project#1186 Add new telemetry service which receives events and immediately sends them. example event sent: ```json { "app_id": "1b%i31CBnblWxHYxSanG", "cpu_name": "11th Gen Intel(R) Core(TM) i5-1135G7 @ 2.40GHz", "created_at": { "nanos_since_epoch": 439482034, "secs_since_epoch": 1734106140 }, "event_name": "checking-latest-version-mmproxy", "event_value": { "percentage": 10, "service": "mmproxy" }, "gpu_name": "Intel(R) Iris(R) Xe Graphics [0x9a49]", "os": "Linux", "user_id": "v3,FZNcifkHKvDUJ9Luwc4xBe5HiGHV,0.8.24,VWE2AdhnnMOqNDd7fcQnqVVEBAeee68KBM2+8K7iznY=", "version": "0.8.24" } ``` Motivation and Context --- This should be useful for tracking how many users are stuck during application setup. We saw some users being stuck at 30% with now feedback. This should help in debugging issues like that. How Has This Been Tested? --- Run application and watch for error message coming from telemetry service. If no error are present that means that events were sent correctly. Also check the telemetry dashboard to check if any messages are present on the server. To verify frontend command I created test button to invoke like this: ```Typescript const sendTelemetry = () => invoke('send_data_telemetry_service', { eventName: 'settings_opened', data: { service: 'frontend-test', percentage: 100 }, }); ``` And found those event present in the kafka dashboard: ```js { "app_id": "CX4h8%%G$xQ0hpnZSu@N", "cpu_name": "11th Gen Intel(R) Core(TM) i5-1135G7 @ 2.40GHz", "created_at": { "nanos_since_epoch": 795656093, "secs_since_epoch": 1736248665 }, "event_name": "settings_opened", "event_value": { "percentage": 100, "service": "frontend-test" }, "gpu_name": "Intel(R) Iris(R) Xe Graphics [0x9a49]", "os": "Linux", "user_id": "v3,FZNcifkHKvDUJ9Luwc4xBe5HiGHV,0.8.40,VWE2AdhnnMOqNDd7fcQnqVVEBAeee68KBM2+8K7iznY", "version": "0.8.40" } ``` What process can a PR reviewer use to test or verify this change? --- Same as above. Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify --------- Co-authored-by: Brian Pearce <brianp@users.noreply.github.com>
## Fixes tari-project#1203 ### [ Summary ] - Marked wallet directory for skipping deletion when `reset_wallet` is false - Added extra check for omitting keychain items in deletion process when `reset_wallet` is false --------- Co-authored-by: Brian Pearce <brianp@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Init PR that aims to merge the work done so for on TU v1 and v2. V2 was about the work on the development of the Tari L2, the Tari Ootle (especially support for running tapplets).
THIS IS STILL A WIP VERSION
Motivation and Context
More about the Tari Universe v2 can be found in the Tari Universe Overview RFC
How Has This Been Tested?
Manually.
What process can a PR reviewer use to test or verify this change?
Breaking Changes
BREAKING CHANGE: Description what the user should do, e.g. delete a database, resync the chain
Still a lot of work needs to be done to make it work as expected so don't merge until is well tested.