-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gpu): make GPU unavailable if all devices are excluded #1375
Open
MCozhusheck
wants to merge
2
commits into
tari-project:main
Choose a base branch
from
MCozhusheck:fix/all-gpu-devices-excluded
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix(gpu): make GPU unavailable if all devices are excluded #1375
MCozhusheck
wants to merge
2
commits into
tari-project:main
from
MCozhusheck:fix/all-gpu-devices-excluded
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianp
requested changes
Jan 15, 2025
Comment on lines
+204
to
+208
if self.gpu_devices.len() <= excluded_gpu_devices.len() { | ||
self.is_available = false; | ||
} else { | ||
self.is_available = true; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
if self.gpu_devices.len() <= excluded_gpu_devices.len() { | |
self.is_available = false; | |
} else { | |
self.is_available = true; | |
} | |
self.is_available = !(self.gpu_devices.len() <= excluded_gpu_devices.len()) |
Comment on lines
+203
to
+207
if (excludedGpuDevices.length === hardware.length) { | ||
set({ gpu: { ...getState().gpu, mining: { ...getState().gpu.mining, is_available: false } } }); | ||
} else { | ||
set({ gpu: { ...getState().gpu, mining: { ...getState().gpu.mining, is_available: true } } }); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
if (excludedGpuDevices.length === hardware.length) { | |
set({ gpu: { ...getState().gpu, mining: { ...getState().gpu.mining, is_available: false } } }); | |
} else { | |
set({ gpu: { ...getState().gpu, mining: { ...getState().gpu.mining, is_available: true } } }); | |
} | |
set({ gpu: { ...getState().gpu, mining: { ...getState().gpu.mining, is_available: !(excludedGpuDevices.length === hardware.length) } } }); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes entire GPU unavailable for gpu mining if all devices were excluded.
Motivation and Context
Right now if all devices are excluded the gpu miner will restart over and over failing each time. This PR makes early check for this case.
How Has This Been Tested?
Before mining - turn on GPU mining and turn off every GPU device then:
xtrgpuminer
process is absent)Also check case if GPU mining is turned on and at least 1 GPU device then check if GPU mining is working as expected.
What process can a PR reviewer use to test or verify this change?
Same as above.
Breaking Changes