-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): airdrop login and code sharing on setup screen #1312
base: main
Are you sure you want to change the base?
Conversation
src/containers/main/Airdrop/AirdropGiftTracker/hooks/useAirdropAuth.ts
Outdated
Show resolved
Hide resolved
@peps Sorry mate. I was about to merge this and now it's conflicted. |
No worries :) Looking into it now |
@brianp it should be ok now. This PR involves moving the Airdrop Login logic into a separate hook I tested pretty thoroughly myself, but when testing make sure to test both...
They're both sharing the same |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brianp @shanimal08 Conflicts fixed |
This adds a new element to the Setup Screen that allows users to log in and share their referral code while they wait for the App Setup process to complete.
@PanchoBubble I moved the Airdrop login functionality to its own hook
useAirdropAuth
which exportshandleAuth
andcheckAuth
.I also disabled the
isFirstLoad
check on theAirdropPermission
component. I now have it hooked up so if the user disabled telemetry the new Share/Login UI will toggle. This makes it pretty obvious that telemetry is required in order to collect gems.Since this changes the code that handles the login functionality and auth checks, we should test the login functionality both on the setup screen and the sidebar.