Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): airdrop login and code sharing on setup screen #1312

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

peps
Copy link
Collaborator

@peps peps commented Dec 26, 2024

This adds a new element to the Setup Screen that allows users to log in and share their referral code while they wait for the App Setup process to complete.

@PanchoBubble I moved the Airdrop login functionality to its own hook useAirdropAuth which exports handleAuth and checkAuth.

I also disabled the isFirstLoad check on the AirdropPermission component. I now have it hooked up so if the user disabled telemetry the new Share/Login UI will toggle. This makes it pretty obvious that telemetry is required in order to collect gems.

Since this changes the code that handles the login functionality and auth checks, we should test the login functionality both on the setup screen and the sidebar.

CleanShot 2024-12-27 at 13 30 54

CleanShot 2024-12-27 at 13 19 28

CleanShot 2024-12-27 at 13 31 47

@peps peps self-assigned this Dec 26, 2024
@peps peps changed the title [WIP] feat(ui): setup screen airdrop login feat(ui): setup screen airdrop login [WIP] Dec 26, 2024
@peps peps changed the title feat(ui): setup screen airdrop login [WIP] feat(ui): airdrop login and code sharing on setup screen Dec 27, 2024
@peps peps marked this pull request as ready for review December 27, 2024 12:30
@brianp
Copy link
Collaborator

brianp commented Jan 14, 2025

@peps Sorry mate. I was about to merge this and now it's conflicted.

@peps
Copy link
Collaborator Author

peps commented Jan 14, 2025

@peps Sorry mate. I was about to merge this and now it's conflicted.

No worries :) Looking into it now

@peps
Copy link
Collaborator Author

peps commented Jan 14, 2025

@brianp it should be ok now. This PR involves moving the Airdrop Login logic into a separate hook useAirdropAuth so any change to the inline logic there will be a conflict.

I tested pretty thoroughly myself, but when testing make sure to test both...

  1. The login functionality on the Setup screen
  2. The login functionality in the Sidebar

They're both sharing the same useAirdropAuth hook to handle the login flow.

Copy link
Collaborator

@shanimal08 shanimal08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just the new conflicts (sorry!)
i like this setup screen app version a lot better:D

btw, not sure when #1335 will go in, but it will likely cause even more conflicts, so not sure if you want to wait for that, or resolve here and i can resolve there after this is merged?

cc @brianp

@peps
Copy link
Collaborator Author

peps commented Jan 15, 2025

@brianp @shanimal08 Conflicts fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants