Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: increase autostartup permissions #1221

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

Misieq01
Copy link
Collaborator

@Misieq01 Misieq01 commented Dec 10, 2024

Fixes #1154

[ Summary ]

  • Extended autolauncher strategy for windows with extra step of creating task schedule
  • Created task in scheduler is responsible for starting universe app with highest permission when user login first time after booting up machine

[ Testing ]

  • Build the app from this PR and then install from .msi
  • Enable auto launch feature and restart machine, app should start automatically
  • Also you should see entry "Tari Universer startup" in task scheduler

@Misieq01 Misieq01 force-pushed the feat/levelup-autostartup-permissions branch from a40f78f to 106d0a8 Compare December 11, 2024 08:44
@Misieq01 Misieq01 requested review from brianp and mmrrnn January 8, 2025 13:08
Copy link
Collaborator

@brianp brianp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, i made this suggestion last year but it failed to post. I'll be testing this today.

src-tauri/src/auto_launcher.rs Show resolved Hide resolved
@brianp
Copy link
Collaborator

brianp commented Jan 9, 2025

On windows 11 this isn't functioning for me. I enable auto-start on system boot, restart the system and nothing starts on boot.

Is there something I could check or debug to help?

@Misieq01
Copy link
Collaborator Author

@brianp Did you tested on dev or build the app from this PR ?

@brianp
Copy link
Collaborator

brianp commented Jan 10, 2025

I built the app locally, and installed via msi

@Misieq01
Copy link
Collaborator Author

I will look into it but remember that it worked just fine on my windows 11

@Misieq01
Copy link
Collaborator Author

@brianp Could you check in windows task scheduler if you got a entry for Tari Universe

@brianp
Copy link
Collaborator

brianp commented Jan 14, 2025

I uninstalled all Tari versions and cleaned directories. Built from PR, re-installed from msi. Turning "Auto-start on system boot" on did not produce any item I can find in the Task Scheduler. Although their tiny little unordered list doesn't make it easy.

@Misieq01
Copy link
Collaborator Author

Misieq01 commented Jan 15, 2025

I uninstalled all Tari versions and cleaned directories. Built from PR, re-installed from msi. Turning "Auto-start on system boot" on did not produce any item I can find in the Task Scheduler. Although their tiny little unordered list doesn't make it easy.

Task scheduler does not has great UI haha. Okay, thanks for putting time in testing it, I will give it a look today, either something broke after updating branch or there is another case on your setup that need to me handled

@Misieq01 Misieq01 force-pushed the feat/levelup-autostartup-permissions branch from 0795657 to 9602872 Compare January 15, 2025 15:24
@Misieq01
Copy link
Collaborator Author

@brianp Tested it and for me it also stopped working, not sure what caused it but removing check of flag from auto_launcher crate and just depending on our app_config flag solved it for me and now it works like it used to before Christmas break

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows: 0.8.2: Auto start on system boot: When user restarts laptop, app does not automatically start
2 participants