fix: calculation of coverage percentage #403
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
locker
reviewed
Nov 13, 2024
| @@ -23,6 +23,7 @@ | |||
| - Fix error trace reporting for functions executed with `Server:exec()` | |||
| (gh-396). | |||
| - Remove pretty-printing of `luatest.log` arguments. | |||
| - Fixed calculation of coverage percentage (gh-402) | |||
There was a problem hiding this comment.
Bad changelog - unclear what exactly was wrong. Would be nice to say that it added uncovered files to the coverage report.
Also, please write a descriptive commit message. It should include Closes #XXX. We don't start subject lines with "fix: ...". Should probably be "Add uncovered files to coverage report".
| @@ -42,6 +53,10 @@ function export.enable() | |||
| for _, item in pairs(export.DEFAULT_EXCLUDE) do | |||
| table.insert(config.exclude, item) | |||
| end | |||
|
|
|||
| runner.data = {} | |||
| find_luas(runner.data, root) | |||
There was a problem hiding this comment.
Accessing undocumented fields of luacov.runner. looks dangerous. At least, this requires a comment.
The only alternative I see is writing a coverage report file with zero counters before initializing luacov.runner. This could be done with luacov.stats.save.
@Totktonada WDYT?
|
Sorry, this has already been fixed here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following small pull request fixes the issue with calculating the test coverage percentage. To achieve this, instead of initializing with an empty statistics list, it is populated with all Lua files from the LUATESTLUACOVROOT directory (by default, this is the project directory).
The CHANGELOG has been updated.