-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add assert_one_of #294
base: master
Are you sure you want to change the base?
Add assert_one_of #294
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't quite get why I was summoned to review luatest PR since I never contributed here and don't know how the infrastructure works, but the patch seems fine.
You can also think about unifying the code with assert_covers
since they do similar things.
32b673f
to
176ac51
Compare
AFAIK we generaly follow the LuaUnit assertion naming (but just snake case variants). There are |
For me, |
BTW, the implementation is not exactly same. You're using Regarding However, I still think that LuaUnit names are good enough and I see no reason to use different ones. |
As for me |
Add
assert_one_of
to assert that the value is one of several alternatives.It could be useful to write tests that support several tarantool versions.