Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SSL support to HTTP server #2285

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Add SSL support to HTTP server #2285

merged 1 commit into from
Nov 22, 2024

Conversation

yngvar-antonsson
Copy link
Collaborator

@yngvar-antonsson yngvar-antonsson commented Nov 19, 2024 •
edited
Loading

I didn't forget about

  • Tests
  • Changelog
  • Documentation

Close #2284

themilchenko
themilchenko approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@themilchenko themilchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm not sure if a test is needed to make sure that everything works fine.

@yngvar-antonsson yngvar-antonsson merged commit 6fed482 into master Nov 22, 2024
23 of 25 checks passed
@yngvar-antonsson yngvar-antonsson deleted the http-ssl branch November 22, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themilchenko themilchenko themilchenko approved these changes

@olegrok olegrok olegrok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new http options to cartridge.cfg
3 participants
@yngvar-antonsson @olegrok @themilchenko