Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix raft failover state transitions #2189

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Fix raft failover state transitions #2189

merged 2 commits into from
Feb 16, 2024

Conversation

yngvar-antonsson
Copy link
Collaborator

@yngvar-antonsson yngvar-antonsson commented Feb 9, 2024 •
edited
Loading

I didn't forget about

  • Tests
  • Changelog

Close #2188

sergepetrenko
sergepetrenko reviewed Feb 15, 2024
View reviewed changes
Copy link

@sergepetrenko sergepetrenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

Two questions from me.

cartridge/failover/raft.lua Show resolved Hide resolved
test/integration/raft_test.lua Outdated Show resolved Hide resolved
sergepetrenko
sergepetrenko approved these changes Feb 16, 2024
View reviewed changes
Copy link

@sergepetrenko sergepetrenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yngvar-antonsson yngvar-antonsson marked this pull request as ready for review February 16, 2024 15:20
@yngvar-antonsson yngvar-antonsson merged commit bcb7eae into master Feb 16, 2024
23 checks passed
@yngvar-antonsson yngvar-antonsson deleted the fix-raft-transitions branch February 16, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergepetrenko sergepetrenko sergepetrenko approved these changes

@filonenko-mikhail filonenko-mikhail filonenko-mikhail approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Master discovery with raft failover may return a dead node as leader
3 participants
@yngvar-antonsson @filonenko-mikhail @sergepetrenko