Apply suggestions from code review

Co-authored-by: Aleksander Klenov <a.a.klenov@ya.ru>
tarantool · Dec 24, 2024 · 9a94218 · 9a94218
1 parent f6f7c91
commit 9a94218
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/cartridge/failover.lua b/cartridge/failover.lua
@@ -432,7 +432,7 @@ local function synchro_promote()
         local ok, err = pcall(box.ctl.promote)
         fiber.testcancel()
         if ok ~= true then
-            log.error('Failed to promote: %s', err)
+            log.error('Failed to promote: %s', err or 'unknown')
         end
         return err
     end
@@ -448,7 +448,7 @@ local function synchro_demote()
         local ok, err = pcall(box.ctl.demote)
         fiber.testcancel()
         if ok ~= true then
-            log.error('Failed to demote: %s', err)
+            log.error('Failed to demote: %s', err or 'unknown')
         end
         return err
     end

diff --git a/cartridge/failover/raft.lua b/cartridge/failover/raft.lua
@@ -150,9 +150,9 @@ local function disable()
     and box_info.synchro.queue ~= nil
     and box_info.synchro.queue.owner ~= 0
     and box_info.synchro.queue.owner == box_info.id then
-        local err = pcall(box.ctl.demote)
-        if err ~= nil then
-            log.error('Failed to demote: %s', err)
+        local ok, err = pcall(box.ctl.demote)
+        if ok ~= true then
+            log.error('Failed to demote: %s', err or 'unknown')
         end
         return err
     end