feat: Add moveBefore and moveAfter for array-nature collection #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: * Add moveBefore and moveAfter API on IndexedCollection * Additional documentations on SignalObserver Test Plan: * Verify unit tests have passed * Create a collection with nature as Array * Populate the collection with a sequence of items * Call moveBefore or moveAfter API * Verify the .items property reflect the movement
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #31 +/- ##
==========================================
- Coverage 95.24% 94.64% -0.61%
==========================================
Files 18 18
Lines 421 448 +27
Branches 68 70 +2
==========================================
+ Hits 401 424 +23
- Misses 12 16 +4
Partials 8 8 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Add moveBefore and moveAfter for array-nature collection
Summary:
Test Plan: