-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove arb and eth goerli networks #608
Conversation
Signed-off-by: avichalp <hi@avichalp.me>
@@ -52,25 +52,6 @@ | |||
"ChainStackCollectFrequency": "15m" | |||
}, | |||
"Chains": [ | |||
{ | |||
"Name": "Ethereum Goerli", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc: @dtbuchholz
Will the validator still support read queries (and other types of gateway requests) for tables on these goerli networks? |
@asutula i don't think so. the tables will still be there in the validator's database but the gateway has this notion of "supported chains". it rejects any query to an unsupported chain |
The query will work, actually. The check of supported chains does not happen in the Either way, an additional comment: if we ever start the validator from scratch again, the data would be lost because the validator wouldn't pick the events of a not-supported chain (we'd still have them in the backups taken when the chain was supported). We don't have the concept of "network was supported between this interval, so pick those events up". |
Thanks for the info @brunocalza.
This implies that if any new validator joins the nework, they won't have the data. Seems we should consider the data gone/unavailable then. I could be smart to delete the tables from the validator state (and Studio's state), but that may be another conversation. |
Summary
This PR removes support for arbitrum and ethereum goerli networks. See #607 for details